-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding release notes for 2.0 GA #405
Adding release notes for 2.0 GA #405
Conversation
* Add Abstraction for BWC tests with a basic test ([#388](https://github.com/opensearch-project/k-NN/pull/388)) | ||
* Add restart upgrade BWC Tests ([#387](https://github.com/opensearch-project/k-NN/pull/387)) | ||
|
||
### Bug Fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove these headings if we don't have any PRs to add in that section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same question, my reason to leave those in the notes - it's clean indication that we do not have any changes for that category. Does it make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, checked previous notes, seems that in general rule is - no change no category. Let me remove empty headings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got your point. But, in all the previous release notes we are only adding the sections that contains PRs. Just want to make things look uniform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I agree. Just pushed commit that corrects this, please check
* Update jacoco version to 0.8.7 to support JDK 17 ([#372](https://github.com/opensearch-project/k-NN/pull/372)) | ||
* Remove rc1 build qualifier for 2.0 GA release ([#395](https://github.com/opensearch-project/k-NN/pull/395)) | ||
|
||
### Refactoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
=========================================
Coverage 84.01% 84.01%
Complexity 911 911
=========================================
Files 130 130
Lines 3879 3879
Branches 359 359
=========================================
Hits 3259 3259
Misses 458 458
Partials 162 162 Continue to review full report at Codecov.
|
Signed-off-by: Martin Gaievski <[email protected]>
77769ed
to
20ec845
Compare
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit a5dd71c)
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit a5dd71c) Co-authored-by: Martin Gaievski <[email protected]>
Signed-off-by: Martin Gaievski [email protected]
Description
Add release notes for 2.1.0 rc1
Issues Resolved
#385
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.