-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BWC tests for Lucene Engine #2313
Merged
jmazanec15
merged 9 commits into
opensearch-project:main
from
buddharajusahil:lucene_bwc_tests
Dec 16, 2024
Merged
Add BWC tests for Lucene Engine #2313
jmazanec15
merged 9 commits into
opensearch-project:main
from
buddharajusahil:lucene_bwc_tests
Dec 16, 2024
+174
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddharajusahil
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
December 7, 2024 00:40
Signed-off-by: Sahil Buddharaju <[email protected]>
Signed-off-by: Sahil Buddharaju <[email protected]>
Signed-off-by: Sahil Buddharaju <[email protected]>
Signed-off-by: Sahil Buddharaju <[email protected]>
Signed-off-by: Sahil Buddharaju <[email protected]>
buddharajusahil
force-pushed
the
lucene_bwc_tests
branch
from
December 7, 2024 00:46
ba0fb03
to
cf5ea14
Compare
@buddharajusahil please fix the failing CIs |
Signed-off-by: Sahil Buddharaju <[email protected]>
qa/restart-upgrade/src/test/java/org/opensearch/knn/bwc/IndexingIT.java
Outdated
Show resolved
Hide resolved
qa/restart-upgrade/src/test/java/org/opensearch/knn/bwc/IndexingIT.java
Outdated
Show resolved
Hide resolved
naveentatikonda
changed the title
Lucene bwc tests (Addresses issue #1725)
Add BWC tests for Lucene Engine
Dec 10, 2024
Signed-off-by: Sahil Buddharaju <[email protected]>
Signed-off-by: Sahil Buddharaju <[email protected]>
Signed-off-by: Sahil Buddharaju <[email protected]>
naveentatikonda
approved these changes
Dec 16, 2024
jmazanec15
approved these changes
Dec 16, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2313-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f50a8f5383935435784711c124715efcff871b48
# Push it to GitHub
git push --set-upstream origin backport/backport-2313-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds bwc tests for Lucene Engine, as there had not been any previously.
Related Issues
Resolves #1725
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.