Validate method parameters only after version 2_17_0 #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding integration test |
k-NN introduced validation to prevent index creation api to accept method paramters that are used by approximate k-NN search algorithm. For ex: create index api accepts model_id, or, method params even if knn index setting was not true before 2.17. However, for index that were created before 2.17 and upgraded to 2.17, will prevent cluster to parse those previously accepted index mapping. Hence, k-NN will allow those paramters for indices that were created before 2.17, but doesn't support those parameters starting 2.17. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
add-version-check-for-validation
branch
from
79baf82 to
07fbc88
Compare
Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
add-version-check-for-validation
branch
from
c93f30f to
4e2ef45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
k-NN introduced validation to prevent index creation api to accept method paramters that are used by approximate k-NN search algorithm. For ex: create index api accepts model_id, or, method params even if knn index setting was not true before 2.17.
However, for index that were created before 2.17 and upgraded to 2.17, will prevent cluster to parse those previously accepted index mapping.
Hence, k-NN will allow those paramters for indices that were created before 2.17, but doesn't support those parameters starting 2.17.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.