[Backport 2.x] Remove default admin credential references in DEVELOPER_GUIDE #1420
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Remove default admin credentials Signed-off-by: Ryan Bogan <[email protected]> * Update developer guide Signed-off-by: Ryan Bogan <[email protected]> * Debug Signed-off-by: Ryan Bogan <[email protected]> * Revert build.gradle changes Signed-off-by: Ryan Bogan <[email protected]> * Update developer guide Signed-off-by: Ryan Bogan <[email protected]> * Remove default password in favor of <admin-password> Signed-off-by: Ryan Bogan <[email protected]> --------- Signed-off-by: Ryan Bogan <[email protected]> (cherry picked from commit 0c000ad)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1420 +/- ##
============================================
+ Coverage 84.87% 84.95% +0.07%
+ Complexity 1253 1252 -1
============================================
Files 162 162
Lines 5131 5131
Branches 493 493
============================================
+ Hits 4355 4359 +4
+ Misses 568 563 -5
- Partials 208 209 +1 ☔ View full report in Codecov by Sentry. |
naveentatikonda
approved these changes
Jan 25, 2024
junqiu-lei
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0c000ad from #1415