-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement in release perf test #1243
Conversation
TESTS="./release-configs/faiss-hnsw/filtering/relaxed-filter/relaxed-filter-test.yml | ||
./release-configs/faiss-hnsw/filtering/restrictive-filter/restrictive-filter-test.yml | ||
./release-configs/faiss-hnsw/test.yml | ||
./release-configs/faiss-hnswpq/test.yml | ||
./release-configs/faiss-ivf/filtering/relaxed-filter/relaxed-filter-test.yml | ||
./release-configs/faiss-ivf/filtering/restrictive-filter/restrictive-filter-test.yml | ||
./release-configs/faiss-ivf/test.yml | ||
./release-configs/faiss-ivfpq/test.yml | ||
./release-configs/lucene-hnsw/filtering/relaxed-filter/relaxed-filter-test.yml | ||
./release-configs/lucene-hnsw/filtering/restrictive-filter/restrictive-filter-test.yml | ||
./release-configs/lucene-hnsw/test.yml | ||
./release-configs/nmslib-hnsw/test.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add some sleep time between running of all the tests to make CPU come down and cluster to become stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add some sleep time between running of all the tests to make CPU come down and cluster to become stable.
Do you think 1 min will be enough for that purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah 1 min is fine.
Codecov Report
@@ Coverage Diff @@
## main #1243 +/- ##
=========================================
Coverage 85.07% 85.07%
Complexity 1210 1210
=========================================
Files 160 160
Lines 4932 4932
Branches 449 449
=========================================
Hits 4196 4196
Misses 537 537
Partials 199 199 |
thanks for raising the PR |
curious if with every next run time changes, as this all is on same cluster, I think some query stuff may be cached after multiple runs? |
@martin-gaievski queries won’t be cached because we delete the index at the start of every run. |
6af7f2d
Signed-off-by: Heemin Kim <[email protected]>
This is what we have been doing for release benchmark test as long as I know. We are not using different cluster for each test run. |
Description
Simply the process to run performance test for release
Previous behavior
"knn.algo_param.index_thread_qty" : 4
After change
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.