Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.11] Fix ignore unmapped minimum version #1240

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9d2086c from #1239

Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit 9d2086c)
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1240 (5ed407a) into 2.11 (f807aa2) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               2.11    #1240      +/-   ##
============================================
+ Coverage     85.00%   85.06%   +0.06%     
- Complexity     1184     1187       +3     
============================================
  Files           155      155              
  Lines          4881     4881              
  Branches        450      450              
============================================
+ Hits           4149     4152       +3     
+ Misses          533      530       -3     
  Partials        199      199              
Files Coverage Δ
.../main/java/org/opensearch/knn/index/IndexUtil.java 61.97% <100.00%> (ø)

... and 3 files with indirect coverage changes

@navneet1v
Copy link
Collaborator

@ryanbogan DCO check is failing here

@navneet1v
Copy link
Collaborator

This can create issues in build lets fix this.

@ryanbogan
Copy link
Member

ryanbogan commented Oct 11, 2023

Not sure why it's happening but this is the error:

 5ed407a21da9f2f2a51fda45d92e5a28e66ef90d    Expected "Ryan Bogan <[email protected]>", but got "Ryan Bogan <[email protected]>".

Looks like it's expecting a forwarding email or something like that.

@navneet1v
Copy link
Collaborator

can you raise the PR again. To make sure that it is resolved.

@ryanbogan ryanbogan closed this Oct 11, 2023
@heemin32
Copy link
Collaborator

Closing in favor of #1242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants