Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add graph creation stats to KNNStats API #1191

Conversation

ryanbogan
Copy link
Member

@ryanbogan ryanbogan commented Oct 4, 2023

Description

Backport of #1141

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1191 (a4d8bd2) into 2.x (39836c6) will increase coverage by 0.14%.
The diff coverage is 92.38%.

@@             Coverage Diff              @@
##                2.x    #1191      +/-   ##
============================================
+ Coverage     84.98%   85.12%   +0.14%     
- Complexity     1168     1187      +19     
============================================
  Files           154      155       +1     
  Lines          4781     4881     +100     
  Branches        442      450       +8     
============================================
+ Hits           4063     4155      +92     
- Misses          520      527       +7     
- Partials        198      199       +1     
Files Coverage Δ
...index/codec/KNN80Codec/KNN80DocValuesConsumer.java 91.03% <100.00%> (+2.33%) ⬆️
...n/index/codec/util/KNNVectorSerializerFactory.java 96.29% <ø> (ø)
...org/opensearch/knn/plugin/stats/KNNGraphValue.java 100.00% <100.00%> (ø)
...java/org/opensearch/knn/plugin/stats/KNNStats.java 100.00% <100.00%> (ø)
...ava/org/opensearch/knn/plugin/stats/StatNames.java 100.00% <100.00%> (ø)
.../opensearch/knn/index/codec/util/KNNCodecUtil.java 77.50% <66.66%> (-16.95%) ⬇️

@martin-gaievski martin-gaievski merged commit 46b54d6 into opensearch-project:2.x Oct 4, 2023
51 of 77 checks passed
@ryanbogan ryanbogan deleted the graph_creation_stats_backport branch October 4, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants