[Backport 2.x] Add ignore_unmapped support in KNNQueryBuilder #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan
changed the title
Signed-off-by: Ryan Bogan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1152 +/- ##
============================================
- Coverage 85.03% 84.91% -0.12%
- Complexity 1160 1168 +8
============================================
Files 154 154
Lines 4751 4781 +30
Branches 434 442 +8
============================================
+ Hits 4040 4060 +20
- Misses 515 523 +8
- Partials 196 198 +2
|
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan
changed the title
ryanbogan
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
Signed-off-by: Ryan Bogan <[email protected]>
navneet1v
approved these changes
Oct 3, 2023
| private static final Version MINIMAL_SUPPORTED_VERSION_FOR_IGNORE_UNMAPPED = Version.V_2_10_0; | ||
| public static final Map<String, Version> minimalRequiredVersionMap = new HashMap<String, Version>() { | ||
| { | ||
| put("filter", MINIMAL_SUPPORTED_VERSION_FOR_LUCENE_HNSW_FILTER); |
There was a problem hiding this comment.
nit: we can use shorter initialization for map here:
public static final Map<String, Version> minimalRequiredVersionMap = Map.of (
"filter", MINIMAL_SUPPORTED_VERSION_FOR_LUCENE_HNSW_FILTER
);
martin-gaievski
approved these changes
Oct 3, 2023
martin-gaievski
merged commit 39836c6
into
opensearch-project:2.x
38 of 67 checks passed
heemin32
added a commit
to heemin32/k-NN
that referenced
this pull request
Oct 11, 2023
heemin32
added a commit
to heemin32/k-NN
that referenced
this pull request
Oct 11, 2023
…opensearch-project#1152)" This reverts commit 39836c6. Signed-off-by: Heemin Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ignore_unmapped support in KNNQueryBuilder
Issues Resolved
#1018
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.