Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding get-ci-image-tag dynamic retrival on CI workflows #1099

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Sep 6, 2023

Description

Adding get-ci-image-tag dynamic retrival on CI workflows

Issues Resolved

opensearch-project/opensearch-build#3966
#1042

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added Enhancements Increases software capabilities beyond original client specifications ci skip-changelog labels Sep 6, 2023
@peterzhuamazon peterzhuamazon self-assigned this Sep 6, 2023
@peterzhuamazon peterzhuamazon force-pushed the knn-workflow-dynamic-docker-images-tags branch from 3072bbe to 031b97a Compare September 6, 2023 22:22
@peterzhuamazon peterzhuamazon marked this pull request as ready for review September 6, 2023 22:29
@peterzhuamazon peterzhuamazon changed the title Test adding get-ci-image-tag dynamic retrival on CI workflows Adding get-ci-image-tag dynamic retrival on CI workflows Sep 6, 2023
@peterzhuamazon peterzhuamazon added backport 1.3 Backports PRs to 1.3 branch backport 2.x labels Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1099 (031b97a) into main (cc5cd7e) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1099      +/-   ##
============================================
+ Coverage     84.95%   85.01%   +0.06%     
  Complexity     1184     1184              
============================================
  Files           159      159              
  Lines          4813     4813              
  Branches        433      433              
============================================
+ Hits           4089     4092       +3     
+ Misses          528      525       -3     
  Partials        196      196              

see 1 file with indirect coverage changes

@navneet1v navneet1v merged commit c051e55 into opensearch-project:main Sep 6, 2023
58 of 62 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1099-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c051e550905ecf1217ad338ffdebeb84563df4aa
# Push it to GitHub
git push --set-upstream origin backport/backport-1099-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-1099-to-1.3.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2023
@navneet1v navneet1v added backport 2.10 backport to 2.10 branch and removed backport 1.3 Backports PRs to 1.3 branch labels Sep 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2023
This was referenced Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.10 backport to 2.10 branch ci Enhancements Increases software capabilities beyond original client specifications skip-changelog
Projects
Development

Successfully merging this pull request may close these issues.

3 participants