Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fixing the backward incompatible changes coming from core in ScoreScriptipt class(#1056) #1063

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

navneet1v
Copy link
Collaborator

@navneet1v navneet1v commented Aug 24, 2023

Description

Fixing the backward incompatible changes coming from core in ScoreScriptipt class(#1056)

This change includes:

  1. Fixing the backward incompatible changes in ScoreScript class. [Feature] Expose term frequency in Painless script score context OpenSearch#9081

Main branch PR: #1056

Issues Resolved

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1063 (8fc8758) into 2.x (8c7cb1b) will decrease coverage by 0.02%.
Report is 1 commits behind head on 2.x.
The diff coverage is 83.67%.

@@             Coverage Diff              @@
##                2.x    #1063      +/-   ##
============================================
- Coverage     85.13%   85.11%   -0.02%     
- Complexity     1148     1159      +11     
============================================
  Files           154      154              
  Lines          4702     4737      +35     
  Branches        428      434       +6     
============================================
+ Hits           4003     4032      +29     
- Misses          506      511       +5     
- Partials        193      194       +1     
Files Changed Coverage Δ
...java/org/opensearch/knn/index/query/KNNWeight.java 85.63% <76.47%> (+<0.01%) ⬆️
...ain/java/org/opensearch/knn/index/KNNSettings.java 83.78% <80.00%> (-0.60%) ⬇️
...g/opensearch/knn/plugin/script/KNNScoreScript.java 100.00% <100.00%> (ø)
...earch/knn/plugin/script/KNNScoreScriptFactory.java 100.00% <100.00%> (ø)
.../opensearch/knn/plugin/script/KNNScoringSpace.java 93.10% <100.00%> (ø)

@navneet1v navneet1v merged commit 50fae34 into opensearch-project:2.x Aug 25, 2023
@navneet1v navneet1v deleted the script-fix branch August 25, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog v2.10.0 Issues targeting release v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants