-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup Search API : Searching both historical rollup and non-rollup data #901
Merged
bowenlan-amzn
merged 45 commits into
opensearch-project:feature/rollup-and-live-search-2.9
from
ronnaksaxena:case2
Sep 30, 2023
Merged
Changes from 40 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
0ea7f53
added response interceptor
ronnaksaxena 4e93b1f
Base case: Query Live and Rollup data with no overlap
ronnaksaxena 7fd394a
finished base case and added integ test
ronnaksaxena f023a39
added to response interceptor
ronnaksaxena 4aa4202
can rewrite request to bucket pipeline
ronnaksaxena c3b5477
trying to rewrite aggregations in a helper function
ronnaksaxena 5d20241
able to create new aggreations but getting shardIndex is not set error
ronnaksaxena 743263b
Can find start and end times for rollup and live index
ronnaksaxena 1f07f21
Handles overlap between 1 live index and 1 rollup index for sum aggre…
ronnaksaxena b4dbc26
added min max aggregations and fixed intersection time calculation
ronnaksaxena 1ee93c6
changed variable name in computeAggregationsWithoutOverlap
ronnaksaxena 4203a60
Added integ tests for nonoverlapping case
ronnaksaxena 72e0aad
added avg and value count aggregation
ronnaksaxena 9b977d2
fixed ktlint and integ test
ronnaksaxena 8ed31e7
changed test and build workflow
ronnaksaxena f0d364f
added integ test for multiple live indices
ronnaksaxena b52fbdc
added test case for alias live indices
ronnaksaxena 820dc24
cleaned up code and moved functions to utils file
ronnaksaxena ef7682f
fixed detekt errors
ronnaksaxena e9fa46c
fixed ktlint error :/'
ronnaksaxena c8d8790
Can run all integ tests at once now
ronnaksaxena 1e3294f
removed DateTimeFromatter
ronnaksaxena 1a7da76
fixed inf interceptor loop, need to pass RollupInterceptorIT.test rol…
ronnaksaxena b145ecf
passes all integ tests
ronnaksaxena a9c6369
fixed detekt errors
ronnaksaxena 495ee4d
deleted rest test
ronnaksaxena 4dd4096
added test back
ronnaksaxena d94fbbd
trying a new workflow build
ronnaksaxena aeeccae
Merge branch 'case2' of https://github.com/ronnaksaxena/index-managem…
ronnaksaxena 4ef546b
added stars to worklow files
ronnaksaxena bf04e32
added unit test
ronnaksaxena d618e90
resolved some PR comments from Bowen
ronnaksaxena 9c567ee
resolved more comments on my PR
ronnaksaxena 79f68e5
removed stars from workflows
ronnaksaxena 768a2bc
testing time of alias test case
ronnaksaxena fb86758
boring, took too long
ronnaksaxena 17df156
commented out last 2 tests
ronnaksaxena e496c57
removed all response interceptor tests
ronnaksaxena 8aa3f81
added one test back
ronnaksaxena 016d161
fixed data stream integ tests
ronnaksaxena 96603eb
commented out breaking tests
ronnaksaxena 35ee9e6
added tests back
ronnaksaxena 06b7b02
removed countdown latch and added coroutines
ronnaksaxena acf1c4b
resolved comments on the PR
ronnaksaxena 9c9d242
resolved PR comments added kotlin docs for methods
ronnaksaxena File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ name: Test and Build Workflow | |
on: | ||
pull_request: | ||
branches: | ||
- "*" | ||
- "**" | ||
push: | ||
branches: | ||
- "*" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
436 changes: 436 additions & 0 deletions
436
src/main/kotlin/org/opensearch/indexmanagement/rollup/interceptor/ResponseInterceptor.kt
Large diffs are not rendered by default.
Oops, something went wrong.
221 changes: 184 additions & 37 deletions
221
src/main/kotlin/org/opensearch/indexmanagement/rollup/interceptor/RollupInterceptor.kt
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this after PR is approved.