-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify test clean logic #609
Unify test clean logic #609
Conversation
d438e92
to
cc3b22f
Compare
Signed-off-by: bowenlan-amzn <[email protected]>
cc3b22f
to
f92a45e
Compare
Signed-off-by: bowenlan-amzn <[email protected]>
8e11ef6
to
3ab7771
Compare
Signed-off-by: bowenlan-amzn <[email protected]>
3ab7771
to
0504d7b
Compare
Codecov Report
@@ Coverage Diff @@
## main #609 +/- ##
============================================
- Coverage 75.32% 75.23% -0.09%
+ Complexity 2605 2593 -12
============================================
Files 330 330
Lines 15111 15115 +4
Branches 2337 2338 +1
============================================
- Hits 11382 11372 -10
- Misses 2397 2409 +12
- Partials 1332 1334 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-609-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d91df69c11d4411be6cb297772a006b310cd43f7
# Push it to GitHub
git push --set-upstream origin backport/backport-609-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * Customize cleanup for multi node test Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]>
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * Customize cleanup for multi node test Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]>
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * Customize cleanup for multi node test Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]>
* Fix all the compile warnings and detekt issues (#603) * Fix all the compile warnings and detekt issues Signed-off-by: bowenlan-amzn <[email protected]> * Fix time capture is 0 Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> * Unify test clean logic (#609) * Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * Customize cleanup for multi node test Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-609-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d91df69c11d4411be6cb297772a006b310cd43f7
# Push it to GitHub
git push --set-upstream origin backport/backport-609-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4 Then, create a pull request where the |
* Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * Customize cleanup for multi node test Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit d91df69)
* Fix all the compile warnings and detekt issues (#603) * Fix all the compile warnings and detekt issues Signed-off-by: bowenlan-amzn <[email protected]> * Fix time capture is 0 Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> * Unify test clean logic (#609) * Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * Customize cleanup for multi node test Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 7a02534)
* Fix all the compile warnings and detekt issues (#603) * Fix all the compile warnings and detekt issues Signed-off-by: bowenlan-amzn <[email protected]> * Fix time capture is 0 Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> * Unify test clean logic (#609) * Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * Customize cleanup for multi node test Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 7a02534) Co-authored-by: bowenlan-amzn <[email protected]>
* Fix all the compile warnings and detekt issues (opensearch-project#603) * Fix all the compile warnings and detekt issues Signed-off-by: bowenlan-amzn <[email protected]> * Fix time capture is 0 Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> * Unify test clean logic (opensearch-project#609) * Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * Customize cleanup for multi node test Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]>
* Fix all the compile warnings and detekt issues (opensearch-project#603) * Fix all the compile warnings and detekt issues Signed-off-by: bowenlan-amzn <[email protected]> * Fix time capture is 0 Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> * Unify test clean logic (opensearch-project#609) * Unify wipe indices logic after tests Signed-off-by: bowenlan-amzn <[email protected]> * Enhance wipeAllIndices function Signed-off-by: bowenlan-amzn <[email protected]> * Customize cleanup for multi node test Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: Ronnak Saxena <[email protected]>
Signed-off-by: bowenlan-amzn [email protected]
Issue #, if available:
Description of changes:
Unify the wipeAllIndices logic in this repo.
Dived deep into the multinode large scale test failures because of remaining tasks after tests. Confirmed it's not realistic to wait for all tasks to disappear in multinode test suite, some observations:
This PR includes the small fix for this issue #608
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.