Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Execution #428

Closed
wants to merge 10 commits into from
Closed

Conversation

ronnaksaxena
Copy link
Contributor

@ronnaksaxena ronnaksaxena commented Jul 25, 2022

Signed-off-by: Ronnak Saxena [email protected]
Issue #, if available:

Description of changes:
•Added a continuous execution option when adding polices to managed indices
•Speeds up execution of indices that can run multiple actions/steps in a single execution cycle within runner logic
•Modified "Add Policy", "Update Managed Index Policy", & "Explain Index" APIs to incorporate continuous execution feature

CheckList:

  • [ X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ronnaksaxena ronnaksaxena force-pushed the main branch 5 times, most recently from f9a1f6b to 0e4960a Compare July 26, 2022 21:27
@downsrob downsrob changed the title Continuous Execution - Ronnak Intern Project Continuous Execution Jul 26, 2022
@ronnaksaxena ronnaksaxena force-pushed the main branch 2 times, most recently from 3323a84 to 4acc051 Compare July 27, 2022 02:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #428 (ceb07ae) into main (0f0ba16) will decrease coverage by 0.16%.
The diff coverage is 45.67%.

@@             Coverage Diff              @@
##               main     #428      +/-   ##
============================================
- Coverage     75.81%   75.65%   -0.17%     
- Complexity     2466     2472       +6     
============================================
  Files           313      313              
  Lines         14411    14503      +92     
  Branches       2227     2249      +22     
============================================
+ Hits          10926    10972      +46     
- Misses         2239     2272      +33     
- Partials       1246     1259      +13     
Impacted Files Coverage Δ
...sport/action/addpolicy/TransportAddPolicyAction.kt 59.88% <0.00%> (ø)
...ment/indexstatemanagement/util/RestHandlerUtils.kt 97.43% <0.00%> (-2.57%) ⬇️
...rch/indexmanagement/snapshotmanagement/SMRunner.kt 64.28% <ø> (ø)
...gement/snapshotmanagement/engine/SMStateMachine.kt 74.79% <ø> (ø)
...m/action/delete/TransportDeleteTransformsAction.kt 74.02% <ø> (ø)
.../action/explain/TransportExplainTransformAction.kt 70.78% <ø> (-2.25%) ⬇️
...transport/action/explain/TransportExplainAction.kt 61.60% <8.77%> (-10.74%) ⬇️
...agement/indexstatemanagement/ManagedIndexRunner.kt 48.11% <50.00%> (+2.01%) ⬆️
...statemanagement/resthandler/RestAddPolicyAction.kt 77.27% <50.00%> (-3.68%) ⬇️
...temanagement/resthandler/RestChangePolicyAction.kt 90.47% <50.00%> (-4.53%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

bowenlan-amzn and others added 8 commits July 29, 2022 18:43
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: Ronnak Saxena <[email protected]>
Signed-off-by: Ronnak Saxena <[email protected]>

Signed-off-by: Ronnak Saxena <[email protected]>
…com>

Signed-off-by: Ronnak Saxena <[email protected]>

Signed-off-by: Ronnak Saxena <[email protected]>
…o that runManagedIndex avoids continuous execution on outdated managed index config

Signed-off-by: Ronnak Saxena <[email protected]>
Signed-off-by: Ronnak Saxena <[email protected]>

Signed-off-by: Ronnak Saxena <[email protected]>
@ronnaksaxena ronnaksaxena marked this pull request as ready for review July 29, 2022 18:45
@ronnaksaxena ronnaksaxena requested a review from a team July 29, 2022 18:45
@downsrob
Copy link
Contributor

downsrob commented Aug 5, 2022

Based on the feedback from the presentation of this feature, we would like a mechanism to support bulk migrating indices to continuous. The change policy API does support wildcards, but it requires a policyID in the request, so users can only bulk change indices to be continuous if the policies are set as well.

Before this feature is released, let's do a minor refactor to allow null policyID values in a ChangePolicyRequest if there is a continuous field present.

@bowenlan-amzn
Copy link
Member

close, dup as #462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants