Bug Fixes in Snapshot Policy: Schedule Editing and Index Expression Display #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skumawat2025
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
skumawat2025
force-pushed
the
bug-snapshot-policy
branch
from
66cc80a to
34c80d6
Compare
RamakrishnaChilaka
approved these changes
Nov 6, 2024
…isplay Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025
force-pushed
the
bug-snapshot-policy
branch
from
34c80d6 to
afcd0fe
Compare
SuZhou-Joe
approved these changes
Nov 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
…isplay (#1207) Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> (cherry picked from commit 657a699) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RamakrishnaChilaka
added a commit
that referenced
this pull request
Dec 16, 2024
…isplay (#1207) (#1208) (cherry picked from commit 657a699) Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Ramakrishna Chilaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #947
This pull request addresses two significant bugs in the snapshot policy functionality:
Schedule Editing Bug:
Fixed an issue where users were unable to modify the snapshot schedule time during policy editing.
Users can now successfully update the snapshot timing as needed.
Index Expression Display Bug:
Resolved a problem where entered index expressions were not displaying correctly, and no snapshots were happening for that policy with correct indices.
The snapshot details page now properly shows the index expressions as strings, replacing the previous [Object][Object] display. Snapshot's are taking place with correct indices.
This fix ensures that users can accurately view and verify their index selections.
Testing:
Verified that snapshot schedule times can be edited and saved correctly.
Confirmed that index expressions are now displayed properly in all relevant sections of the UI.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.