bug-fix: Create snapshot policy button reloads the dashboard #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
|
The changes LGTM. |
astute-decipher
approved these changes
Oct 4, 2024
Signed-off-by: Sandeep Kumawat <[email protected]>
SuZhou-Joe
approved these changes
Oct 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* bug-fix: Create snapshot policy button reloads the dashboard Signed-off-by: Sandeep Kumawat <[email protected]> * Update page snapshots to latest Signed-off-by: Sandeep Kumawat <[email protected]> --------- Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> (cherry picked from commit 64014ef) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 18, 2024
…1188) * bug-fix: Create snapshot policy button reloads the dashboard * Update page snapshots to latest --------- (cherry picked from commit 64014ef) Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sandeep Kumawat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR achieves an improvement in Snapshot Policy page. Currently clicking on create snapshot policy page re-loads the entire dashboard.
Before this change.
Screenshare.-.2024-10-04.2_15_18.PM.mp4
After this change.
Screenshare.-.2024-10-04.2_16_35.PM.mp4
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.