-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fit and Finish Changes for Snapshot Management Pages #1157
Fit and Finish Changes for Snapshot Management Pages #1157
Conversation
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
564766e
to
5eb62ab
Compare
Looks good! |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1157-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6c815fe13341bf21e928c4f4fcdc137a42a2f890
# Push it to GitHub
git push --set-upstream origin backport/backport-1157-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1157-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6c815fe13341bf21e928c4f4fcdc137a42a2f890
# Push it to GitHub
git push --set-upstream origin backport/backport-1157-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x Then, create a pull request where the |
…ect#1157) Signed-off-by: Sandeep Kumawat <[email protected]> --------- Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]>
…ect#1157) Signed-off-by: Sandeep Kumawat <[email protected]> --------- Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> Signed-off-by: Sandeep Kumawat <[email protected]>
* Fit and Finish Changes for Snapshot Management Pages Signed-off-by: Sandeep Kumawat <[email protected]> * Fixes Signed-off-by: Sandeep Kumawat <[email protected]> * incorporate ux feedback Signed-off-by: Sandeep Kumawat <[email protected]> --------- Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> (cherry picked from commit 6c815fe) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fit and Finish Changes for Snapshot Management Pages * Fixes * incorporate ux feedback --------- (cherry picked from commit 6c815fe) Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sandeep Kumawat <[email protected]>
Description
This PR tried to make Fit and Finish changes for the snapshot management pages.
Video.
Screenshare.-.2024-09-02.4_51_59.PM.mp4
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.