Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit and Finish Changes for Snapshot Management Pages #1157

Merged

Conversation

skumawat2025
Copy link
Contributor

@skumawat2025 skumawat2025 commented Aug 29, 2024

Description

This PR tried to make Fit and Finish changes for the snapshot management pages.

  1. Index Snapshots
  2. Snapshot policies.
  3. Snapshot repositories.

Video.

Screenshare.-.2024-09-02.4_51_59.PM.mp4

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sandeep Kumawat added 3 commits September 2, 2024 16:26
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
@skumawat2025 skumawat2025 force-pushed the fit-and-finish-snapshots branch from 564766e to 5eb62ab Compare September 2, 2024 11:16
@tandonks
Copy link
Contributor

tandonks commented Sep 2, 2024

Looks good!

@SuZhou-Joe SuZhou-Joe merged commit 6c815fe into opensearch-project:main Sep 2, 2024
10 of 13 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1157-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6c815fe13341bf21e928c4f4fcdc137a42a2f890
# Push it to GitHub
git push --set-upstream origin backport/backport-1157-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1157-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1157-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6c815fe13341bf21e928c4f4fcdc137a42a2f890
# Push it to GitHub
git push --set-upstream origin backport/backport-1157-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1157-to-2.x.

skumawat2025 added a commit to skumawat2025/index-management-dashboards-plugin that referenced this pull request Sep 3, 2024
…ect#1157)

Signed-off-by: Sandeep Kumawat <[email protected]>

---------

Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
skumawat2025 added a commit to skumawat2025/index-management-dashboards-plugin that referenced this pull request Sep 3, 2024
…ect#1157)

Signed-off-by: Sandeep Kumawat <[email protected]>

---------

Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
* Fit and Finish Changes for Snapshot Management Pages

Signed-off-by: Sandeep Kumawat <[email protected]>

* Fixes

Signed-off-by: Sandeep Kumawat <[email protected]>

* incorporate ux feedback

Signed-off-by: Sandeep Kumawat <[email protected]>

---------

Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
(cherry picked from commit 6c815fe)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 3, 2024
* Fit and Finish Changes for Snapshot Management Pages



* Fixes



* incorporate ux feedback



---------



(cherry picked from commit 6c815fe)

Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sandeep Kumawat <[email protected]>
@skumawat2025 skumawat2025 deleted the fit-and-finish-snapshots branch September 4, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants