-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface change for MDS and deprecating dataSourceLabel from the URL #1031
Merged
SuZhou-Joe
merged 1 commit into
opensearch-project:main
from
RamakrishnaChilaka:interface_change_mds
Apr 12, 2024
Merged
Interface change for MDS and deprecating dataSourceLabel from the URL #1031
SuZhou-Joe
merged 1 commit into
opensearch-project:main
from
RamakrishnaChilaka:interface_change_mds
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamakrishnaChilaka
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
April 11, 2024 08:12
RamakrishnaChilaka
force-pushed
the
interface_change_mds
branch
from
April 11, 2024 08:21
4c148d8
to
0a05f05
Compare
Signed-off-by: Ramakrishna Chilaka <[email protected]>
RamakrishnaChilaka
force-pushed
the
interface_change_mds
branch
from
April 12, 2024 04:35
0a05f05
to
6caf5dd
Compare
SuZhou-Joe
approved these changes
Apr 12, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1031-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed98e4ab820ebe7fd436548a4e0793757a4cbb30
# Push it to GitHub
git push --set-upstream origin backport/backport-1031-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x Then, create a pull request where the |
RamakrishnaChilaka
added a commit
to RamakrishnaChilaka/index-management-dashboards-plugin
that referenced
this pull request
Apr 12, 2024
…opensearch-project#1031) Signed-off-by: Ramakrishna Chilaka <[email protected]> (cherry picked from commit ed98e4a)
RamakrishnaChilaka
added a commit
to RamakrishnaChilaka/index-management-dashboards-plugin
that referenced
this pull request
Apr 12, 2024
…opensearch-project#1031) Signed-off-by: Ramakrishna Chilaka <[email protected]> (cherry picked from commit ed98e4a)
1 task
RamakrishnaChilaka
added a commit
to RamakrishnaChilaka/index-management-dashboards-plugin
that referenced
this pull request
Apr 15, 2024
…opensearch-project#1031) Signed-off-by: Ramakrishna Chilaka <[email protected]> (cherry picked from commit ed98e4a)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 15, 2024
…#1031) (#1036) Signed-off-by: Ramakrishna Chilaka <[email protected]> (cherry picked from commit ed98e4a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DataSourceMenu core changed its interface i.e., props change. Also incorporates changes for opensearch-project/OpenSearch-Dashboards#6276
Also depreceates dataSourceLabel from the URL, as dataSourceId can be used to fetch dataSourceLabel. (opensearch-project/OpenSearch-Dashboards#6274)
Issues Resolved
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.