Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface change for MDS and deprecating dataSourceLabel from the URL #1031

Merged

Conversation

RamakrishnaChilaka
Copy link
Collaborator

Description

DataSourceMenu core changed its interface i.e., props change. Also incorporates changes for opensearch-project/OpenSearch-Dashboards#6276

Also depreceates dataSourceLabel from the URL, as dataSourceId can be used to fetch dataSourceLabel. (opensearch-project/OpenSearch-Dashboards#6274)

Issues Resolved

NA

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe SuZhou-Joe merged commit ed98e4a into opensearch-project:main Apr 12, 2024
9 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1031-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed98e4ab820ebe7fd436548a4e0793757a4cbb30
# Push it to GitHub
git push --set-upstream origin backport/backport-1031-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1031-to-2.x.

RamakrishnaChilaka added a commit to RamakrishnaChilaka/index-management-dashboards-plugin that referenced this pull request Apr 12, 2024
RamakrishnaChilaka added a commit to RamakrishnaChilaka/index-management-dashboards-plugin that referenced this pull request Apr 12, 2024
RamakrishnaChilaka added a commit to RamakrishnaChilaka/index-management-dashboards-plugin that referenced this pull request Apr 15, 2024
SuZhou-Joe pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants