Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value in denylist #583

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

heemin32
Copy link
Collaborator

@heemin32 heemin32 commented Nov 6, 2023

Description

Add default value in denylist

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a unit test that is checking this default value? Not a blocker, just maybe add it in a separate PR

@heemin32 heemin32 force-pushed the internal branch 5 times, most recently from 2c0f9a0 to 1c7e8ff Compare November 6, 2023 20:15
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #583 (0504aa3) into main (96d2dab) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #583      +/-   ##
============================================
- Coverage     89.03%   89.00%   -0.04%     
+ Complexity      767      766       -1     
============================================
  Files            93       93              
  Lines          2746     2746              
  Branches        223      223              
============================================
- Hits           2445     2444       -1     
  Misses          221      221              
- Partials         80       81       +1     
Files Coverage Δ
...earch/geospatial/ip2geo/common/Ip2GeoSettings.java 94.44% <100.00%> (ø)

... and 3 files with indirect coverage changes

@heemin32 heemin32 merged commit e91b47c into opensearch-project:main Nov 6, 2023
15 checks passed
@heemin32 heemin32 deleted the internal branch November 6, 2023 20:51
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 6, 2023
Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit e91b47c)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 6, 2023
Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit e91b47c)
heemin32 added a commit that referenced this pull request Nov 6, 2023
Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit e91b47c)

Co-authored-by: Heemin Kim <[email protected]>
heemin32 added a commit that referenced this pull request Nov 6, 2023
Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit e91b47c)

Co-authored-by: Heemin Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport PR to 2.x branch backport 2.11 Backport to 2.11 branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants