-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run integ tests in parallel with build #94
Conversation
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
=========================================
Coverage 81.82% 81.82%
Complexity 285 285
=========================================
Files 30 30
Lines 1117 1117
Branches 125 125
=========================================
Hits 914 914
Misses 158 158
Partials 45 45 |
Signed-off-by: Daniel Widdis <[email protected]>
To discuss the 3 JDKs mentioned in the PR description. The below JDK version are needed for the respective branches/development purpose.
We can run 17 on just ubuntu though. |
So this should be 17 (ubuntu only) and 20 on main, and 17 (ubuntu only) and 11 on backport? |
If we are running 11 on just backport/2.x, that way we won't be able to catch any issues on main which are not supported on JDK11. |
Signed-off-by: Daniel Widdis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
* Run integ tests in parallel with build Signed-off-by: Daniel Widdis <[email protected]> * Repo check on all runs, reduce JDK17 runs to ubuntu only Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: Joshua Palis <[email protected]> (cherry picked from commit c84321f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Run integ tests in parallel with build (#94) * Run integ tests in parallel with build Signed-off-by: Daniel Widdis <[email protected]> * Repo check on all runs, reduce JDK17 runs to ubuntu only Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: Joshua Palis <[email protected]> (cherry picked from commit c84321f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Remove JDK20 from backport CI Signed-off-by: Daniel Widdis <[email protected]> * Remove the other JDK20 Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joshua Palis <[email protected]> Co-authored-by: Daniel Widdis <[email protected]>
Description
Inspired by discussion on #84 (Thanks @owaiskazi19)
Removes the repo conditional on spotless and javadoc checks, so you don't need to submit the PR to get alerted about those failures.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.