-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force tests jackson dependencies to 2.18 #911
Conversation
Signed-off-by: Owais <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
=========================================
Coverage 78.07% 78.07%
Complexity 995 995
=========================================
Files 99 99
Lines 4621 4621
Branches 431 431
=========================================
Hits 3608 3608
Misses 833 833
Partials 180 180 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Owais <[email protected]>
3e11199
to
3e1b0a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-911-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 30966d6be53a99e7af880d7a11603d57cdc98da7
# Push it to GitHub
git push --set-upstream origin backport/backport-911-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x Then, create a pull request where the |
@owaiskazi19 @junweid62 one of you should do this backport :) |
Hey @owaiskazi19, could you help out with this backport? I’m currently tied up with bug fixing over on the Trineo side and might not have the time to dive deep into this right now. Thanks a lot in advance! |
Was already on it :) Here you go #912 |
Description
Coming from comment. Forced tests jackson dependencies to 2.18
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.