Incrementally remove resources from workflow state during deprovisioning #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
============================================
- Coverage 78.04% 78.01% -0.03%
- Complexity 977 982 +5
============================================
Files 97 97
Lines 4554 4576 +22
Branches 423 426 +3
============================================
+ Hits 3554 3570 +16
- Misses 823 829 +6
Partials 177 177 ☔ View full report in Codecov by Sentry. |
owaiskazi19
approved these changes
Oct 7, 2024
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
incremental-deprovision-state
branch
from
55fd673 to
86ac8ea
Compare
amitgalitz
approved these changes
Oct 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
…ing (#898) * Add method to delete a resource from the resources_created field Signed-off-by: Daniel Widdis <[email protected]> * Update deprovisioned resources incrementally Signed-off-by: Daniel Widdis <[email protected]> * Use Log4j ParameterizedMessage for string substitutions Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 2f52b7e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Oct 9, 2024
…ing deprovisioning (#910) Incrementally remove resources from workflow state during deprovisioning (#898) * Add method to delete a resource from the resources_created field * Update deprovisioned resources incrementally * Use Log4j ParameterizedMessage for string substitutions --------- (cherry picked from commit 2f52b7e) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes resources from the workflow state list during deprovision incrementally. Retains the existing full-list update as a backup option.
Related Issues
Resolves #780
Resolves #691
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.