Handle Not Found deprovision exceptions as successful deletions #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
deprovision-success-on-delete
branch
from
3eca955 to
e708990
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
============================================
- Coverage 75.76% 75.69% -0.07%
- Complexity 833 834 +1
============================================
Files 88 88
Lines 4035 4045 +10
Branches 371 373 +2
============================================
+ Hits 3057 3062 +5
- Misses 824 828 +4
- Partials 154 155 +1 ☔ View full report in Codecov by Sentry. |
74 tasks
owaiskazi19
approved these changes
Jul 25, 2024
amitgalitz
approved these changes
Jul 25, 2024
amitgalitz
reviewed
Jul 25, 2024
src/main/java/org/opensearch/flowframework/workflow/DeleteAgentStep.java
Show resolved
Hide resolved
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 034dff7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 034dff7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jul 25, 2024
…deletions (#806) Handle Not Found deprovision exceptions as successful deletions (#805) (cherry picked from commit 034dff7) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Jul 25, 2024
… deletions (#807) Handle Not Found deprovision exceptions as successful deletions (#805) (cherry picked from commit 034dff7) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Treats a NOT_FOUND exception on deprovisioning agents and models as successful deprovision.
Related Issues
Fixes #803
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.