Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Improve Template and WorkflowState builders #793

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f40890c from #778.

* Simplify Template builder instantiation

Signed-off-by: Daniel Widdis <[email protected]>

* Add ability to more easily update WorkflowState

Signed-off-by: Daniel Widdis <[email protected]>

* Changelog, initialize template parser

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit f40890c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.76%. Comparing base (81b199f) to head (8958398).

Files Patch % Lines
...framework/indices/FlowFrameworkIndicesHandler.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #793      +/-   ##
============================================
+ Coverage     75.41%   75.76%   +0.34%     
- Complexity      816      833      +17     
============================================
  Files            88       88              
  Lines          3998     4035      +37     
  Branches        362      371       +9     
============================================
+ Hits           3015     3057      +42     
+ Misses          825      824       -1     
+ Partials        158      154       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 7506139 into 2.x Jul 18, 2024
30 of 31 checks passed
@dbwiddis dbwiddis deleted the backport/backport-778-to-2.x branch July 18, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant