Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lower NodeJS version on GH runners for security test #765

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Jul 8, 2024

Description

Temporary workaround for failing security test until container is updated

Issues Resolved

Fixes #759

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Jul 8, 2024
@amitgalitz
Copy link
Member

Spotless check failing

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.30%. Comparing base (dae810c) to head (f87544d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #765      +/-   ##
============================================
- Coverage     74.37%   74.30%   -0.08%     
  Complexity      745      745              
============================================
  Files            84       84              
  Lines          3825     3825              
  Branches        333      333              
============================================
- Hits           2845     2842       -3     
- Misses          825      829       +4     
+ Partials        155      154       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have an issue to revert this temporary solution

@dbwiddis
Copy link
Member Author

dbwiddis commented Jul 8, 2024

We should have an issue to revert this temporary solution

We are one of many plugins doing this. IT's being tracked here: opensearch-project/opensearch-build#4379

@dbwiddis dbwiddis merged commit c76fb3a into opensearch-project:main Jul 8, 2024
20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 8, 2024
Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit c76fb3a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dbwiddis dbwiddis deleted the ci-node-fix branch July 8, 2024 20:23
dbwiddis pushed a commit that referenced this pull request Jul 8, 2024
…test (#770)

Allow lower NodeJS version on GH runners for security test (#765)


(cherry picked from commit c76fb3a)

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis added a commit that referenced this pull request Aug 19, 2024
dbwiddis added a commit that referenced this pull request Aug 20, 2024
* Increment version to 2.13.1-SNAPSHOT

Signed-off-by: opensearch-ci-bot <[email protected]>

* Downgrade macos CI to non-aarch64 runner

Signed-off-by: Daniel Widdis <[email protected]>

* Allow lower NodeJS version on GH runners for security test (#765)

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: opensearch-ci-bot <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>
Co-authored-by: Daniel Widdis <[email protected]>
dbwiddis pushed a commit that referenced this pull request Oct 9, 2024
…test (#770)

Allow lower NodeJS version on GH runners for security test (#765)


(cherry picked from commit c76fb3a)

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler pushed a commit that referenced this pull request Oct 9, 2024
* Increment version to 2.14.1-SNAPSHOT

Signed-off-by: opensearch-ci-bot <[email protected]>

* [Backport 2.x] Allow lower NodeJS version on GH runners for security test (#770)

Allow lower NodeJS version on GH runners for security test (#765)


(cherry picked from commit c76fb3a)

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: opensearch-ci-bot <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Security Integ Tests are failing due to Container NodeJS version
3 participants