Allow strings for boolean workflow step parameters #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
============================================
+ Coverage 72.20% 72.24% +0.03%
- Complexity 682 686 +4
============================================
Files 82 82
Lines 3562 3574 +12
Branches 290 294 +4
============================================
+ Hits 2572 2582 +10
- Misses 859 861 +2
Partials 131 131 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Widdis <[email protected]>
owaiskazi19
reviewed
Apr 19, 2024
src/main/java/org/opensearch/flowframework/workflow/RegisterRemoteModelStep.java
Show resolved
Hide resolved
owaiskazi19
reviewed
Apr 19, 2024
src/test/java/org/opensearch/flowframework/workflow/RegisterModelGroupStepTests.java
Show resolved
Hide resolved
amitgalitz
approved these changes
Apr 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Allow strings for boolean workflow step parameters Signed-off-by: Daniel Widdis <[email protected]> * Reduce redundancy in similar tests Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit b8e4ed0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Apr 23, 2024
Allow strings for boolean workflow step parameters (#671) * Allow strings for boolean workflow step parameters * Reduce redundancy in similar tests --------- (cherry picked from commit b8e4ed0) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows
"true"or"false"strings when boolean parameters are expected.Issues Resolved
Fixes #669
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.