Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Guardrail field for remote model #622

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

owaiskazi19
Copy link
Member

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Mar 27, 2024
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
@dbwiddis dbwiddis changed the title Added new field guarddail for remote model Added new Guardrail field for remote model Mar 28, 2024
Signed-off-by: Joshua Palis <[email protected]>
@joshpalis joshpalis marked this pull request as ready for review March 28, 2024 02:00
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 72.39%. Comparing base (f9d832f) to head (7fd499b).

Files Patch % Lines
...g/opensearch/flowframework/model/WorkflowNode.java 0.00% 5 Missing and 3 partials ⚠️
...lowframework/workflow/RegisterRemoteModelStep.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #622      +/-   ##
============================================
- Coverage     72.54%   72.39%   -0.16%     
  Complexity      684      684              
============================================
  Files            82       82              
  Lines          3526     3535       +9     
  Branches        285      288       +3     
============================================
+ Hits           2558     2559       +1     
- Misses          845      850       +5     
- Partials        123      126       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Owais Kazi <[email protected]>
@owaiskazi19 owaiskazi19 merged commit 4a12730 into opensearch-project:main Mar 28, 2024
31 of 32 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 28, 2024
* Added new field guarddail for remote model

Signed-off-by: Owais Kazi <[email protected]>

* Fixed parsing

Signed-off-by: Owais Kazi <[email protected]>

* Deserialize

Signed-off-by: Owais Kazi <[email protected]>

* fixing guardrails

Signed-off-by: Joshua Palis <[email protected]>

* Added break

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Co-authored-by: Joshua Palis <[email protected]>
(cherry picked from commit 4a12730)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 28, 2024
* Added new field guarddail for remote model

Signed-off-by: Owais Kazi <[email protected]>

* Fixed parsing

Signed-off-by: Owais Kazi <[email protected]>

* Deserialize

Signed-off-by: Owais Kazi <[email protected]>

* fixing guardrails

Signed-off-by: Joshua Palis <[email protected]>

* Added break

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Co-authored-by: Joshua Palis <[email protected]>
(cherry picked from commit 4a12730)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19 pushed a commit that referenced this pull request Mar 28, 2024
Added new Guardrail field for remote model (#622)

* Added new field guarddail for remote model



* Fixed parsing



* Deserialize



* fixing guardrails



* Added break



---------




(cherry picked from commit 4a12730)

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Palis <[email protected]>
owaiskazi19 pushed a commit that referenced this pull request Mar 28, 2024
Added new Guardrail field for remote model (#622)

* Added new field guarddail for remote model



* Fixed parsing



* Deserialize



* fixing guardrails



* Added break



---------




(cherry picked from commit 4a12730)

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Palis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants