-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new Guardrail field for remote model #622
Merged
owaiskazi19
merged 5 commits into
opensearch-project:main
from
owaiskazi19:fix-guardrails
Mar 28, 2024
Merged
Added new Guardrail field for remote model #622
owaiskazi19
merged 5 commits into
opensearch-project:main
from
owaiskazi19:fix-guardrails
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
changed the title
Added new field guarddail for remote model
Added new Guardrail field for remote model
Mar 28, 2024
Signed-off-by: Joshua Palis <[email protected]>
joshpalis
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
March 28, 2024 02:00
joshpalis
approved these changes
Mar 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
============================================
- Coverage 72.54% 72.39% -0.16%
Complexity 684 684
============================================
Files 82 82
Lines 3526 3535 +9
Branches 285 288 +3
============================================
+ Hits 2558 2559 +1
- Misses 845 850 +5
- Partials 123 126 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
approved these changes
Mar 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Added new field guarddail for remote model Signed-off-by: Owais Kazi <[email protected]> * Fixed parsing Signed-off-by: Owais Kazi <[email protected]> * Deserialize Signed-off-by: Owais Kazi <[email protected]> * fixing guardrails Signed-off-by: Joshua Palis <[email protected]> * Added break Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: Joshua Palis <[email protected]> Co-authored-by: Joshua Palis <[email protected]> (cherry picked from commit 4a12730) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Added new field guarddail for remote model Signed-off-by: Owais Kazi <[email protected]> * Fixed parsing Signed-off-by: Owais Kazi <[email protected]> * Deserialize Signed-off-by: Owais Kazi <[email protected]> * fixing guardrails Signed-off-by: Joshua Palis <[email protected]> * Added break Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: Joshua Palis <[email protected]> Co-authored-by: Joshua Palis <[email protected]> (cherry picked from commit 4a12730) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Mar 28, 2024
Added new Guardrail field for remote model (#622) * Added new field guarddail for remote model * Fixed parsing * Deserialize * fixing guardrails * Added break --------- (cherry picked from commit 4a12730) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joshua Palis <[email protected]>
owaiskazi19
pushed a commit
that referenced
this pull request
Mar 28, 2024
Added new Guardrail field for remote model (#622) * Added new field guarddail for remote model * Fixed parsing * Deserialize * fixing guardrails * Added break --------- (cherry picked from commit 4a12730) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joshua Palis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.