Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ingest pipeline integ test #614

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

joshpalis
Copy link
Member

Description

Adds a pipeline ID to the getPipelines() helper method to return only the pipeline configuration of the given pipeline ID
More details can be found in the attached issue

Issues Resolved

Addressing distribution build failure here

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.75%. Comparing base (8820d89) to head (fa4ce74).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #614   +/-   ##
=========================================
  Coverage     72.75%   72.75%           
  Complexity      681      681           
=========================================
  Files            82       82           
  Lines          3491     3491           
  Branches        279      279           
=========================================
  Hits           2540     2540           
  Misses          832      832           
  Partials        119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice analysis and fix!

@joshpalis joshpalis merged commit 871b0c5 into opensearch-project:main Mar 26, 2024
44 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-614-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 871b0c58f76c5aecd372b428d942293bbfa94437
# Push it to GitHub
git push --set-upstream origin backport/backport-614-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-614-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.13 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.13
# Create a new branch
git switch --create backport/backport-614-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 871b0c58f76c5aecd372b428d942293bbfa94437
# Push it to GitHub
git push --set-upstream origin backport/backport-614-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.13

Then, create a pull request where the base branch is 2.13 and the compare/head branch is backport/backport-614-to-2.13.

@joshpalis
Copy link
Member Author

will raise manual backports to 2.x and 2.13

joshpalis added a commit to joshpalis/opensearch-ai-flow-framework that referenced this pull request Apr 1, 2024
amitgalitz pushed a commit that referenced this pull request Apr 1, 2024
* Fixing ingest pipeline integ test (#614)

Signed-off-by: Joshua Palis <[email protected]>

* Adding initial rest, transport actions for orchestration. Search response processor step

Signed-off-by: Joshua Palis <[email protected]>

* Fixing transport action

Signed-off-by: Joshua Palis <[email protected]>

* reverting change to resttestcase

Signed-off-by: Joshua Palis <[email protected]>

* Adding javadocs

Signed-off-by: Joshua Palis <[email protected]>

* fixing checkstyle

Signed-off-by: Joshua Palis <[email protected]>

* removing extra common value

Signed-off-by: Joshua Palis <[email protected]>

* Fixing errors

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants