Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing default semantic use case integration test #604

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

joshpalis
Copy link
Member

Description

Addresses failed distribution build test : #599 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.75%. Comparing base (fc96ebf) to head (0c57add).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #604   +/-   ##
=========================================
  Coverage     72.75%   72.75%           
  Complexity      681      681           
=========================================
  Files            82       82           
  Lines          3491     3491           
  Branches        279      279           
=========================================
  Hits           2540     2540           
  Misses          832      832           
  Partials        119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owaiskazi19
Copy link
Member

One question. How the test is failing for distribution build though? Since it contains all the plugins already.

@joshpalis
Copy link
Member Author

One question. How the test is failing for distribution build though? Since it contains all the plugins already.

So the distribution build is failing since all plugin integration tests run on the same cluster, this particular integration test of ours assumes the neural search plugin is not in our cluster since our we dont have that plugin dependency in our build.gradle.

@owaiskazi19
Copy link
Member

owaiskazi19 commented Mar 22, 2024

So the distribution build is failing since all plugin integration tests run on the same cluster, this particular integration test of ours assumes the neural search plugin is not in our cluster since our we dont have that plugin dependency in our build.gradle.

How did this test pass on GHA then since we don't have dependency in build.gradle?

@joshpalis
Copy link
Member Author

How did this test pass on GHA then?

When we run integration tests on our CI, the cluster only has ML Commons and Flow Framework

@owaiskazi19
Copy link
Member

When we run integration tests on our CI, the cluster only has ML Commons and Flow Framework

I see it was a failure test case that's why no issue on our GHA

@joshpalis joshpalis merged commit 8e962bf into opensearch-project:main Mar 22, 2024
44 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-604-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8e962bf12530b3b0224ea0560366538617663ca1
# Push it to GitHub
git push --set-upstream origin backport/backport-604-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-604-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.13 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.13
# Create a new branch
git switch --create backport/backport-604-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8e962bf12530b3b0224ea0560366538617663ca1
# Push it to GitHub
git push --set-upstream origin backport/backport-604-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.13

Then, create a pull request where the base branch is 2.13 and the compare/head branch is backport/backport-604-to-2.13.

@joshpalis
Copy link
Member Author

will raise manual PRs for the backports since this modifies the FlowFrameworkRestTestCase file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants