-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing register agent tests #595
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
=========================================
Coverage 72.75% 72.75%
Complexity 681 681
=========================================
Files 82 82
Lines 3491 3491
Branches 279 279
=========================================
Hits 2540 2540
Misses 832 832
Partials 119 119 ☔ View full report in Codecov by Sentry. |
Seeing some failures in integration tests, seems its an issue with the ML Indices handler being unable to create the ml model index
|
Are we missing a mandatory field when creating the model? CC: @dhrubo-os |
These errors are occurring on ML-Commons 2.x branch tests: see https://github.com/opensearch-project/ml-commons/actions/runs/8340647023/job/22825002139 for example. Test run history for 2.x branch: https://github.com/opensearch-project/ml-commons/actions/workflows/CI-workflow.yml?query=branch%3A2.x CC: @rbhavna @dhrubo-os |
a713c69
to
d90e86f
Compare
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
We fixed the bug now: opensearch-project/ml-commons#2234 |
Signed-off-by: Joshua Palis <[email protected]>
* Fixing register agent tests Signed-off-by: Joshua Palis <[email protected]> * fixing register agent IT Signed-off-by: Joshua Palis <[email protected]> * Fixing agent type Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit ebcc8f7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fixing register agent tests Signed-off-by: Joshua Palis <[email protected]> * fixing register agent IT Signed-off-by: Joshua Palis <[email protected]> * Fixing agent type Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit ebcc8f7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Fixing register agent tests (#595) * Fixing register agent tests * fixing register agent IT * Fixing agent type --------- (cherry picked from commit ebcc8f7) Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Fixing register agent tests (#595) * Fixing register agent tests * fixing register agent IT * Fixing agent type --------- (cherry picked from commit ebcc8f7) Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Fixes register agent tests failing due to opensearch-project/ml-commons#2204
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.