Fixed static fields initialization in WorkflowStepFactory #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
force-pushed
the
fix-workflow-step
branch
from
4d2bbaa to
1104881
Compare
owaiskazi19
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=========================================
Coverage 72.00% 72.00%
- Complexity 609 612 +3
=========================================
Files 78 78
Lines 3222 3201 -21
Branches 247 246 -1
=========================================
- Hits 2320 2305 -15
+ Misses 789 783 -6
Partials 113 113 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Feb 21, 2024
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
fix-workflow-step
branch
from
1104881 to
fc36eb8
Compare
amitgalitz
approved these changes
Feb 21, 2024
joshpalis
approved these changes
Feb 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
Fixed static fields initialization Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit 24bf51a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Feb 21, 2024
…ory (#533) Fixed static fields initialization in WorkflowStepFactory (#532) Fixed static fields initialization (cherry picked from commit 24bf51a) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed static fields initialization. Pulling the
Supplier<WorkflowStep>inside the enum over complicates the initialization of the static fields. Reverting the stepMap initialization inside theWorkflowStepFactoryconstructor.Also, removed the unused
clusterServiceandclientpassed.Issues Resolved
Fixes #531
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.