Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env varibale to fix codecov #497

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

owaiskazi19
Copy link
Member

Description

Describe what this change achieves.

Issues Resolved

Fixes #490

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c5dd2f8) 71.91% compared to head (30cd3fc) 71.75%.
Report is 4 commits behind head on main.

Files Patch % Lines
...mework/workflow/AbstractRetryableWorkflowStep.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #497      +/-   ##
============================================
- Coverage     71.91%   71.75%   -0.16%     
+ Complexity      621      620       -1     
============================================
  Files            78       78              
  Lines          3133     3133              
  Branches        234      235       +1     
============================================
- Hits           2253     2248       -5     
- Misses          776      781       +5     
  Partials        104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this PR includes codecov report, this obviously works!

@owaiskazi19 owaiskazi19 merged commit 625844d into opensearch-project:main Feb 7, 2024
30 of 37 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 7, 2024
Signed-off-by: owaiskazi19 <[email protected]>
(cherry picked from commit 625844d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Feb 7, 2024
Add env varibale to fix codecov (#497)


(cherry picked from commit 625844d)

Signed-off-by: owaiskazi19 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] CodeCov no longer works after upgrade to v4 of the action
3 participants