Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding comment to clarify use of default admin credentials #435

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

joshpalis
Copy link
Member

@joshpalis joshpalis commented Jan 23, 2024

Description

Updates build.gradle with comments explaining use of default admin credentials and moves security integration test cluster set up from ext under testClusters.integTest

Issues Resolved

#310
Handling comment : #418 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshpalis joshpalis added the backport 2.x backport PRs to 2.x branch label Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4a31d0) 71.88% compared to head (1394394) 71.88%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #435   +/-   ##
=========================================
  Coverage     71.88%   71.88%           
  Complexity      620      620           
=========================================
  Files            78       78           
  Lines          3126     3126           
  Branches        236      236           
=========================================
  Hits           2247     2247           
  Misses          772      772           
  Partials        107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making this less confusing!

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
@joshpalis joshpalis changed the title Changing default admin password Adding comment to clarify use of default admin credentials Jan 23, 2024
@owaiskazi19
Copy link
Member

@prudhvigodithi can you take a look of the change?

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty @joshpalis !

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in. Any changes mentioned by @prudhvigodithi can be addressed in the follow up PR.

@owaiskazi19 owaiskazi19 merged commit a9219eb into opensearch-project:main Jan 24, 2024
24 of 25 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 24, 2024
* Changing default admin password

Signed-off-by: Joshua Palis <[email protected]>

* testing

Signed-off-by: Joshua Palis <[email protected]>

* Adding more comments

Signed-off-by: Joshua Palis <[email protected]>

* Moving secure integ test cluster configuration unter testCluster.integTest

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
Co-authored-by: Owais Kazi <[email protected]>
(cherry picked from commit a9219eb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis pushed a commit that referenced this pull request Jan 24, 2024
…ials (#444)

Adding comment to clarify use of default admin credentials (#435)

* Changing default admin password



* testing



* Adding more comments



* Moving secure integ test cluster configuration unter testCluster.integTest



---------



(cherry picked from commit a9219eb)

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Owais Kazi <[email protected]>
@prudhvigodithi
Copy link
Member

Thanks @joshpalis, just one comment, the change was made from zipArchive to secureIntegTestPluginArchive and moved the security code from ext{} block to integTest block. I'm fine with the code moving to integTest block but curious on why zipArchive was just looking at maven local and failing without trying other declared repositories{}. Whereas secureIntegTestPluginArchive pulls the security zip from https://aws.oss.sonatype.org/content/repositories/snapshots. If we were able to debug this we can continue to use zipArchive without secureIntegTestPluginArchive.
Thank you
Adding @gaiksaya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants