-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding comment to clarify use of default admin credentials #435
Conversation
Signed-off-by: Joshua Palis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=========================================
Coverage 71.88% 71.88%
Complexity 620 620
=========================================
Files 78 78
Lines 3126 3126
Branches 236 236
=========================================
Hits 2247 2247
Misses 772 772
Partials 107 107 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making this less confusing!
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
…gTest Signed-off-by: Joshua Palis <[email protected]>
@prudhvigodithi can you take a look of the change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty @joshpalis !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in. Any changes mentioned by @prudhvigodithi can be addressed in the follow up PR.
* Changing default admin password Signed-off-by: Joshua Palis <[email protected]> * testing Signed-off-by: Joshua Palis <[email protected]> * Adding more comments Signed-off-by: Joshua Palis <[email protected]> * Moving secure integ test cluster configuration unter testCluster.integTest Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> Co-authored-by: Owais Kazi <[email protected]> (cherry picked from commit a9219eb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ials (#444) Adding comment to clarify use of default admin credentials (#435) * Changing default admin password * testing * Adding more comments * Moving secure integ test cluster configuration unter testCluster.integTest --------- (cherry picked from commit a9219eb) Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Owais Kazi <[email protected]>
Thanks @joshpalis, just one comment, the change was made from |
Description
Updates build.gradle with comments explaining use of default admin credentials and moves security integration test cluster set up from
ext
undertestClusters.integTest
Issues Resolved
#310
Handling comment : #418 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.