-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around JDK 21.0.2 bug impacting scaling executors #429
Conversation
Signed-off-by: Daniel Widdis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
============================================
+ Coverage 71.72% 71.87% +0.15%
- Complexity 618 619 +1
============================================
Files 78 78
Lines 3133 3133
Branches 238 238
============================================
+ Hits 2247 2252 +5
+ Misses 778 774 -4
+ Partials 108 107 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JDK 21 😓
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-429-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 42e4cd4e231d526aa37f9699f7c6a667706af3d6
# Push it to GitHub
git push --set-upstream origin backport/backport-429-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x Then, create a pull request where the |
@dbwiddis Does this need to be backported to 2.x? I dont see any usage of JDK 21 within our 2.x CI, however I do see JDK 21 being used for our 2.x security test workflow here. Now I'm curious if we should even be testing security with JDK 21 for our security enabled integration tests for 2.x since we're not using it for the other workflows. Looking at our 2.x CI, seems security tests with JDK 21 are failing : https://github.com/opensearch-project/flow-framework/actions/runs/7593631134/job/20684298446. Ill raise a PR to remove this |
Description
Restricts CI GitHub Actions to run on JDK 21.0.1 until https://bugs.openjdk.org/browse/JDK-8323659 is released and deployed to runners.
Issues Resolved
Fixes #426
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.