Change thread pool to a ScalingExecutorBuilder #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
=========================================
Coverage 71.84% 71.85%
Complexity 614 614
=========================================
Files 79 79
Lines 3083 3084 +1
Branches 237 237
=========================================
+ Hits 2215 2216 +1
Misses 763 763
Partials 105 105 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Jan 19, 2024
amitgalitz
approved these changes
Jan 19, 2024
|
btw just for reference I think we used fixed as that was used by ml-commons here: https://github.com/opensearch-project/ml-commons/blob/41fac826c8fd1182f83c1f3f6b301bf17022eb2f/plugin/src/main/java/org/opensearch/ml/plugin/MachineLearningPlugin.java#L784 |
jackiehanyang
approved these changes
Jan 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 789fc4d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jan 19, 2024
Change thread pool to a ScalingExecutorBuilder (#421) (cherry picked from commit 789fc4d) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes Flow Framework thread pool to use a ScalingExecutorBuilder
FixedExecutorBuilderestablishes a maximum queue size which is arbitrary and not scalableResizableExecutorBuilderallowing users to manually change this isn't used muchScalingExecutorBuilderis widely used across OpenSearch and plugins and is clearly the preferred option here unless we know better. (Which we don't.)Matches "generic" thread pool type, with different number of processors since it's more narrowly focused.
Uses similar threadpool to AD except with shorter keepalive to correspond to most OpenSearch thread pool times, and uses full number of allocated processors (smaller # than generic).
Allows user to change # of processors per node via settings.
Issues Resolved
Fixes #420
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.