Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/checkout action to v4 #402

Closed

Conversation

mend-for-github-com[bot]
Copy link
Contributor

@mend-for-github-com mend-for-github-com bot commented Jan 12, 2024

This PR contains the following updates:

Package Type Update Change
actions/checkout action major v3 -> v4

Release Notes

actions/checkout (actions/checkout)

v4

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf2cad0) 71.84% compared to head (fb2390e) 71.68%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #402      +/-   ##
============================================
- Coverage     71.84%   71.68%   -0.17%     
+ Complexity      614      613       -1     
============================================
  Files            79       79              
  Lines          3083     3083              
  Branches        237      237              
============================================
- Hits           2215     2210       -5     
- Misses          763      767       +4     
- Partials        105      106       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owaiskazi19
Copy link
Member

@joshpalis can you check why security test workflow failed here?

@joshpalis
Copy link
Member

We use checkoutv1 due to this issue, KNN does the same.

/usr/bin/docker exec  1b956a9a0c0[3](https://github.com/opensearch-project/flow-framework/actions/runs/7508543231/job/20444167492?pr=402#step:9:3)[4](https://github.com/opensearch-project/flow-framework/actions/runs/7508543231/job/20444167492?pr=402#step:9:4)b0d6784[5](https://github.com/opensearch-project/flow-framework/actions/runs/7508543231/job/20444167492?pr=402#step:9:5)de[6](https://github.com/opensearch-project/flow-framework/actions/runs/7508543231/job/20444167492?pr=402#step:9:6)8dd22bee4c2931e122[7](https://github.com/opensearch-project/flow-framework/actions/runs/7508543231/job/20444167492?pr=402#step:9:7)2b4f93e4e01e025e3ced0 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libc.so.6: version `GLIBC_2.2[8](https://github.com/opensearch-project/flow-framework/actions/runs/7508543231/job/20444167492?pr=402#step:9:8)' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libc.so.6: version `GLIBC_2.25' not found (required by /__e/node20/bin/node)

Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this PR, for the test_security workflow, we'll want to keep using v1

@owaiskazi19
Copy link
Member

owaiskazi19 commented Jan 13, 2024

Blocking this PR, for the test_security workflow, we'll want to keep using v1

This looks like version conflict between the CI image and checkout for GLIBC. Unless docker image updates the version, v4 won't work. Can you try updating to v3 and see if it fails with the same errror?

@dbwiddis
Copy link
Member

The docker/node20 issues are v4. We use v3 in our other actions successfully.

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
@mend-for-github-com mend-for-github-com bot force-pushed the whitesource-remediate/actions-checkout-4.x branch from a34e6c0 to fb2390e Compare January 17, 2024 21:21
@dbwiddis
Copy link
Member

Closing this issue to prevent Renovate from generating PR for v4.

I updated to v3 in #413.

Both setup-java and checkout actions v4 require Node 20 which is incompatible with the docker images.

@dbwiddis dbwiddis closed this Jan 17, 2024
Copy link
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 4.x releases. But if you manually upgrade to 4.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants