Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Create Index Building block #38

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Adds Create Index Building block #38

merged 6 commits into from
Sep 25, 2023

Conversation

owaiskazi19
Copy link
Member

Description

Adds Create Index Building block for the workflow setup and logging functionality in the project.

Issues Resolved

Part of #21

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Sep 13, 2023
@owaiskazi19 owaiskazi19 force-pushed the create-index branch 2 times, most recently from 7423e9b to 44dc4a4 Compare September 16, 2023 00:01
@dbwiddis dbwiddis mentioned this pull request Sep 16, 2023
Closed
@dbwiddis dbwiddis mentioned this pull request Sep 18, 2023
Merged
@owaiskazi19 owaiskazi19 force-pushed the create-index branch 3 times, most recently from b76e7f7 to 02123bd Compare September 19, 2023 21:24
@owaiskazi19 owaiskazi19 marked this pull request as ready for review September 22, 2023 16:57
@opensearch-project opensearch-project deleted a comment from codecov bot Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #38 (44da4d5) into main (a574f47) will increase coverage by 0.87%.
The diff coverage is 78.37%.

@@             Coverage Diff              @@
##               main      #38      +/-   ##
============================================
+ Coverage     74.26%   75.14%   +0.87%     
- Complexity       42       47       +5     
============================================
  Files             6        7       +1     
  Lines           136      173      +37     
  Branches         16       18       +2     
============================================
+ Hits            101      130      +29     
- Misses           25       32       +7     
- Partials         10       11       +1
Files Changed Coverage Δ
.../opensearch/flowframework/FlowFrameworkPlugin.java 0.00% <0.00%> (ø)
...ramework/workflow/CreateIndex/CreateIndexStep.java 85.29% <85.29%> (ø)

dbwiddis
dbwiddis reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review. A few substantive and a few non-substantive requests.

src/main/java/org/opensearch/flowframework/FlowFrameworkPlugin.java Show resolved Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateIndex/CreateIndexStep.java Outdated Show resolved Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateIndex/CreateIndexStep.java Show resolved Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateIndex/CreateIndexStep.java Show resolved Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateIndex/CreateIndexStep.java Outdated Show resolved Hide resolved
src/test/java/org/opensearch/flowframework/workflow/CreateIndex/CreateIndexStepTests.java Outdated Show resolved Hide resolved
src/test/java/org/opensearch/flowframework/workflow/CreateIndex/CreateIndexStepTests.java Outdated Show resolved Hide resolved
src/test/java/org/opensearch/flowframework/workflow/CreateIndex/CreateIndexStepTests.java Outdated Show resolved Hide resolved
src/test/java/org/opensearch/flowframework/workflow/CreateIndex/CreateIndexStepTests.java Outdated Show resolved Hide resolved
src/test/resources/template/datademo.json Outdated Show resolved Hide resolved
@dbwiddis dbwiddis mentioned this pull request Sep 22, 2023
Merged
@owaiskazi19
Addressed PR Comments
44da4d5 
Signed-off-by: Owais Kazi <[email protected]>
This was referenced Sep 25, 2023
Closed
Merged
@owaiskazi19 owaiskazi19 merged commit a97b7d0 into opensearch-project:main Sep 25, 2023
10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 25, 2023
@github-actions
Adds Create Index Building block (#38)
a3b94b9 
* Initial impelmentation of CreateIndex

Signed-off-by: Owais Kazi <[email protected]>

* Adds CreateIndex building block

Signed-off-by: Owais Kazi <[email protected]>

* Integrated WorkflowData and made the request async

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR comments

Signed-off-by: Owais Kazi <[email protected]>

* Added unit test and type field for fetching the payload

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR Comments

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit a97b7d0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 25, 2023
Merged
owaiskazi19 pushed a commit that referenced this pull request Sep 25, 2023
@opensearch-trigger-bot @github-actions
[Backport 2.x] Adds Create Index Building block (#57)
0a45e8f 
Adds Create Index Building block  (#38)

* Initial impelmentation of CreateIndex



* Adds CreateIndex building block



* Integrated WorkflowData and made the request async



* Addressed PR comments



* Added unit test and type field for fetching the payload



* Addressed PR Comments



---------


(cherry picked from commit a97b7d0)

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis added a commit that referenced this pull request Sep 25, 2023
@dbwiddis
Change WorkflowData from interface to class (#54)
a530739 
* Change WorkflowData from interface to class

Signed-off-by: Daniel Widdis <[email protected]>

* Disable flaky test

Signed-off-by: Daniel Widdis <[email protected]>

* Rebase with changes from #38

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 25, 2023
@github-actions
Change WorkflowData from interface to class (#54)
b08d35f 
* Change WorkflowData from interface to class

Signed-off-by: Daniel Widdis <[email protected]>

* Disable flaky test

Signed-off-by: Daniel Widdis <[email protected]>

* Rebase with changes from #38

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit a530739)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis pushed a commit that referenced this pull request Sep 25, 2023
@opensearch-trigger-bot @github-actions
[Backport 2.x] Change WorkflowData from interface to class (#58)
04a63e1 
Change WorkflowData from interface to class (#54)

* Change WorkflowData from interface to class



* Disable flaky test



* Rebase with changes from #38



---------


(cherry picked from commit a530739)

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@joshpalis joshpalis joshpalis approved these changes

@jackiehanyang jackiehanyang jackiehanyang approved these changes

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

Assignees
No one assigned
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owaiskazi19 @dbwiddis @jackiehanyang @joshpalis