Include previous node substitutions in nested lists and maps #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
substitutions
branch
from
ea9bde9 to
ecf3b2a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
============================================
+ Coverage 72.30% 72.40% +0.09%
- Complexity 574 580 +6
============================================
Files 72 72
Lines 3001 3011 +10
Branches 230 232 +2
============================================
+ Hits 2170 2180 +10
Misses 727 727
Partials 104 104 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Jan 5, 2024
amitgalitz
approved these changes
Jan 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 2799107) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Jan 5, 2024
…d maps (#373) Include previous node substitutions in nested lists and maps (#371) (cherry picked from commit 2799107) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends the substitution pattern
${{ previousNode.key }}to work inside nested maps and lists in the user inputs.Issues Resolved
Fixes #368
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.