Prevent duplicate inferred edges #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
============================================
+ Coverage 71.45% 71.47% +0.01%
+ Complexity 563 562 -1
============================================
Files 73 73
Lines 2999 3001 +2
Branches 229 230 +1
============================================
+ Hits 2143 2145 +2
Misses 746 746
Partials 110 110 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Jan 2, 2024
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
remove-dupe-edges
branch
from
7cb96be to
20e46c4
Compare
amitgalitz
approved these changes
Jan 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 2, 2024
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit dd32d55) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jan 2, 2024
Prevent duplicate inferred edges (#346) (cherry picked from commit dd32d55) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#334 added functionality to infer edges from previous node inputs. In rare edge cases where a node may have multiple outputs used as inputs, this could result in duplicate edges in the stored template.
While this doesn't impact the parsing (which converts to a set before running the algorithm) it could be confusing to users. Added
distinct()to the stream to eliminate this. Also improved some of the stream implementations in the Workflow Process Sorter.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.