Use current timestamps for registering agent #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Daniel Widdis <[email protected]>
ohltyler
reviewed
Dec 27, 2023
ohltyler
approved these changes
Dec 27, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
* Use current timestamps for registering agent Signed-off-by: Daniel Widdis <[email protected]> * Remove other non-required keys and handle nulls Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 74533f2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 27, 2023
Use current timestamps for registering agent (#325) * Use current timestamps for registering agent * Remove other non-required keys and handle nulls --------- (cherry picked from commit 74533f2) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Registering an agent normally uses the current time for creation and last updated. These fields should not be provided by a user.
There is a mismatch between the required fields in
workflowstep.jsonand the Required/Optional fields in the Workflow Step itself (and no null handling for omission of some fields). This should probably be reviewed in a bit more detail.Issues Resolved
Fixes #324
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.