-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integ tests for search state api, deprovision api, and delete api #313
Merged
jackiehanyang
merged 6 commits into
opensearch-project:main
from
jackiehanyang:integTest
Dec 22, 2023
Merged
Add integ tests for search state api, deprovision api, and delete api #313
jackiehanyang
merged 6 commits into
opensearch-project:main
from
jackiehanyang:integTest
Dec 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
jackiehanyang
force-pushed
the
integTest
branch
from
December 22, 2023 19:57
eab0210
to
bea24d2
Compare
Signed-off-by: Jackie Han <[email protected]>
jackiehanyang
force-pushed
the
integTest
branch
from
December 22, 2023 20:32
b2e74e3
to
35c9ce1
Compare
Signed-off-by: Jackie Han <[email protected]>
jackiehanyang
changed the title
[Testing]add integ tests for search state api, deprovision api, and delete api
Add integ tests for search state api, deprovision api, and delete api
Dec 22, 2023
jackiehanyang
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler and
amitgalitz
as code owners
December 22, 2023 21:53
dbwiddis
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job taking over this task!
ohltyler
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nice!
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
…#313) * add integ tests for search state api, deprovision api, and delete api Signed-off-by: Jackie Han <[email protected]> * spotless check clean up Signed-off-by: Jackie Han <[email protected]> * add timeout Signed-off-by: Jackie Han <[email protected]> * add more timeout Signed-off-by: Jackie Han <[email protected]> * Add thread sleep to wait for deletion to complete Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit 4efbc95) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
added a commit
that referenced
this pull request
Dec 24, 2023
… and delete api (#316) * Add integ tests for search state api, deprovision api, and delete api (#313) * add integ tests for search state api, deprovision api, and delete api Signed-off-by: Jackie Han <[email protected]> * spotless check clean up Signed-off-by: Jackie Han <[email protected]> * add timeout Signed-off-by: Jackie Han <[email protected]> * add more timeout Signed-off-by: Jackie Han <[email protected]> * Add thread sleep to wait for deletion to complete Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit 4efbc95) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix 2.x compatibility Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds integration test cases to cover search state api, deprovision api, and delete api
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.