Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integ tests for search state api, deprovision api, and delete api #313

Merged
merged 6 commits into from
Dec 22, 2023

Conversation

jackiehanyang
Copy link
Collaborator

@jackiehanyang jackiehanyang commented Dec 22, 2023

Description

This pr adds integration test cases to cover search state api, deprovision api, and delete api

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Dec 22, 2023
Signed-off-by: Jackie Han <[email protected]>
@jackiehanyang jackiehanyang changed the title [Testing]add integ tests for search state api, deprovision api, and delete api Add integ tests for search state api, deprovision api, and delete api Dec 22, 2023
@jackiehanyang jackiehanyang marked this pull request as ready for review December 22, 2023 21:53
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job taking over this task!

Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice!

@jackiehanyang jackiehanyang merged commit 4efbc95 into opensearch-project:main Dec 22, 2023
19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 22, 2023
…#313)

* add integ tests for search state api, deprovision api, and delete api

Signed-off-by: Jackie Han <[email protected]>

* spotless check clean up

Signed-off-by: Jackie Han <[email protected]>

* add timeout

Signed-off-by: Jackie Han <[email protected]>

* add more timeout

Signed-off-by: Jackie Han <[email protected]>

* Add thread sleep to wait for deletion to complete

Signed-off-by: Jackie Han <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit 4efbc95)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis added a commit that referenced this pull request Dec 24, 2023
… and delete api (#316)

* Add integ tests for search state api, deprovision api, and delete api (#313)

* add integ tests for search state api, deprovision api, and delete api

Signed-off-by: Jackie Han <[email protected]>

* spotless check clean up

Signed-off-by: Jackie Han <[email protected]>

* add timeout

Signed-off-by: Jackie Han <[email protected]>

* add more timeout

Signed-off-by: Jackie Han <[email protected]>

* Add thread sleep to wait for deletion to complete

Signed-off-by: Jackie Han <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit 4efbc95)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix 2.x compatibility

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Daniel Widdis <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants