[Feature/agent_framework] Add Delete Agent Step #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
force-pushed
the
delete-agent
branch
from
1be9b50 to
a50dad5
Compare
owaiskazi19
reviewed
Dec 4, 2023
src/main/java/org/opensearch/flowframework/workflow/DeleteAgentStep.java
Outdated
Show resolved
Hide resolved
dbwiddis
force-pushed
the
delete-agent
branch
from
a50dad5 to
97f1d5f
Compare
dbwiddis
requested review from
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
|
You might need to add the step to the enum as well. |
The register agent resource is already there, this would delete the same resource (agent id) |
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
delete-agent
branch
from
97f1d5f to
42a9fe3
Compare
owaiskazi19
approved these changes
Dec 5, 2023
amitgalitz
reviewed
Dec 5, 2023
src/main/java/org/opensearch/flowframework/workflow/DeleteAgentStep.java
Show resolved
Hide resolved
amitgalitz
approved these changes
Dec 5, 2023
dbwiddis
merged commit 9b9c406
into
opensearch-project:feature/agent_framework
10 checks passed
28 tasks
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
Delete Agent Step Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
Delete Agent Step Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
that referenced
this pull request
Dec 18, 2023
Delete Agent Step Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
Delete Agent Step Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
that referenced
this pull request
Dec 18, 2023
Delete Agent Step Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a workflow step to delete an agent (opposite of register).
Issues Resolved
Part of #89
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.