[Feature/agent_framework] Actually make the WorkflowStepFactory a Factory #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
changed the title
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
step-factory
branch
from
50c45dd to
32a6425
Compare
owaiskazi19
approved these changes
Dec 3, 2023
owaiskazi19
reviewed
Dec 3, 2023
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Show resolved
Hide resolved
owaiskazi19
merged commit 66fc688
into
opensearch-project:feature/agent_framework
10 checks passed
28 tasks
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…tory (opensearch-project#243) Actually make the WorkflowStepFactory a Factory Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…tory (opensearch-project#243) Actually make the WorkflowStepFactory a Factory Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
that referenced
this pull request
Dec 18, 2023
…tory (#243) Actually make the WorkflowStepFactory a Factory Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
…tory (opensearch-project#243) Actually make the WorkflowStepFactory a Factory Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
that referenced
this pull request
Dec 18, 2023
…tory (#243) Actually make the WorkflowStepFactory a Factory Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generates a new instance of a workflow step using a
Supplier(as a Factory should!) rather than returning the same instance every time.Issues Resolved
Fixes #241
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.