Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Util method to fetch inputs from parameters, content, and previous step output #234

Merged

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Dec 1, 2023

Description

Adds a Util method to fetch required and optional inputs. Priority is given to:

  • Output of previous input steps explicitly stated in the template
  • The current node's input parameters (from template)
  • The current node's input content (from template)
  • Any matching key in any previous step output

If the fetched value is of the form ${{ foo.bar }} then it fetches the value of key bar from step foo.

In addition to the parsing method, I've implemented it in some of the existing steps as an example. Some implementations break existing step tests (because missing input exceptions are different) and can be done later; doing them while awaiting review, but merging this earlier will permit it to be used for current step development.

Issues Resolved

Fixes #210

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition Dan, everything looks so much cleaner now. Approved, but just had one question for clarification

@dbwiddis dbwiddis merged commit 54ab4c7 into opensearch-project:feature/agent_framework Dec 2, 2023
10 checks passed
@dbwiddis dbwiddis deleted the prev-node branch December 2, 2023 06:08
dbwiddis added a commit to dbwiddis/flow-framework that referenced this pull request Dec 15, 2023
…s step output (opensearch-project#234)

* Util method to get required inputs

Signed-off-by: Daniel Widdis <[email protected]>

* Implement parsing in some of the steps

Signed-off-by: Daniel Widdis <[email protected]>

* Handle parsing exceptions in the future

Signed-off-by: Daniel Widdis <[email protected]>

* Improve exception handling

Signed-off-by: Daniel Widdis <[email protected]>

* More steps using the new input parsing

Signed-off-by: Daniel Widdis <[email protected]>

* Update Delete Connector Step with parsing util

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis added a commit that referenced this pull request Dec 18, 2023
…s step output (#234)

* Util method to get required inputs

Signed-off-by: Daniel Widdis <[email protected]>

* Implement parsing in some of the steps

Signed-off-by: Daniel Widdis <[email protected]>

* Handle parsing exceptions in the future

Signed-off-by: Daniel Widdis <[email protected]>

* Improve exception handling

Signed-off-by: Daniel Widdis <[email protected]>

* More steps using the new input parsing

Signed-off-by: Daniel Widdis <[email protected]>

* Update Delete Connector Step with parsing util

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis added a commit to dbwiddis/flow-framework that referenced this pull request Dec 18, 2023
…s step output (opensearch-project#234)

* Util method to get required inputs

Signed-off-by: Daniel Widdis <[email protected]>

* Implement parsing in some of the steps

Signed-off-by: Daniel Widdis <[email protected]>

* Handle parsing exceptions in the future

Signed-off-by: Daniel Widdis <[email protected]>

* Improve exception handling

Signed-off-by: Daniel Widdis <[email protected]>

* More steps using the new input parsing

Signed-off-by: Daniel Widdis <[email protected]>

* Update Delete Connector Step with parsing util

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis added a commit that referenced this pull request Dec 18, 2023
…s step output (#234)

* Util method to get required inputs

Signed-off-by: Daniel Widdis <[email protected]>

* Implement parsing in some of the steps

Signed-off-by: Daniel Widdis <[email protected]>

* Handle parsing exceptions in the future

Signed-off-by: Daniel Widdis <[email protected]>

* Improve exception handling

Signed-off-by: Daniel Widdis <[email protected]>

* More steps using the new input parsing

Signed-off-by: Daniel Widdis <[email protected]>

* Update Delete Connector Step with parsing util

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants