-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Util method to fetch inputs from parameters, content, and previous step output #234
Merged
dbwiddis
merged 6 commits into
opensearch-project:feature/agent_framework
from
dbwiddis:prev-node
Dec 2, 2023
Merged
Add Util method to fetch inputs from parameters, content, and previous step output #234
dbwiddis
merged 6 commits into
opensearch-project:feature/agent_framework
from
dbwiddis:prev-node
Dec 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
December 1, 2023 08:28
This was referenced Dec 1, 2023
joshpalis
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition Dan, everything looks so much cleaner now. Approved, but just had one question for clarification
owaiskazi19
approved these changes
Dec 2, 2023
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
merged commit Dec 2, 2023
54ab4c7
into
opensearch-project:feature/agent_framework
10 checks passed
28 tasks
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…s step output (opensearch-project#234) * Util method to get required inputs Signed-off-by: Daniel Widdis <[email protected]> * Implement parsing in some of the steps Signed-off-by: Daniel Widdis <[email protected]> * Handle parsing exceptions in the future Signed-off-by: Daniel Widdis <[email protected]> * Improve exception handling Signed-off-by: Daniel Widdis <[email protected]> * More steps using the new input parsing Signed-off-by: Daniel Widdis <[email protected]> * Update Delete Connector Step with parsing util Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
that referenced
this pull request
Dec 18, 2023
…s step output (#234) * Util method to get required inputs Signed-off-by: Daniel Widdis <[email protected]> * Implement parsing in some of the steps Signed-off-by: Daniel Widdis <[email protected]> * Handle parsing exceptions in the future Signed-off-by: Daniel Widdis <[email protected]> * Improve exception handling Signed-off-by: Daniel Widdis <[email protected]> * More steps using the new input parsing Signed-off-by: Daniel Widdis <[email protected]> * Update Delete Connector Step with parsing util Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
…s step output (opensearch-project#234) * Util method to get required inputs Signed-off-by: Daniel Widdis <[email protected]> * Implement parsing in some of the steps Signed-off-by: Daniel Widdis <[email protected]> * Handle parsing exceptions in the future Signed-off-by: Daniel Widdis <[email protected]> * Improve exception handling Signed-off-by: Daniel Widdis <[email protected]> * More steps using the new input parsing Signed-off-by: Daniel Widdis <[email protected]> * Update Delete Connector Step with parsing util Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
that referenced
this pull request
Dec 18, 2023
…s step output (#234) * Util method to get required inputs Signed-off-by: Daniel Widdis <[email protected]> * Implement parsing in some of the steps Signed-off-by: Daniel Widdis <[email protected]> * Handle parsing exceptions in the future Signed-off-by: Daniel Widdis <[email protected]> * Improve exception handling Signed-off-by: Daniel Widdis <[email protected]> * More steps using the new input parsing Signed-off-by: Daniel Widdis <[email protected]> * Update Delete Connector Step with parsing util Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Util method to fetch required and optional inputs. Priority is given to:
If the fetched value is of the form
${{ foo.bar }}
then it fetches the value of keybar
from stepfoo
.In addition to the parsing method, I've implemented it in some of the existing steps as an example. Some implementations break existing step tests (because missing input exceptions are different) and can be done later; doing them while awaiting review, but merging this earlier will permit it to be used for current step development.
Issues Resolved
Fixes #210
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.