Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added build script to generate artifacts #166

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Added build script to generate artifacts #166

merged 6 commits into from
Nov 21, 2023

Conversation

owaiskazi19
Copy link
Member

Description

  • Added build script to generate artifacts
  • Added artifacts and sources jar
  • Handle git command issue while building the plugin with manifest

Issues Resolved

Part of #165

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Nov 14, 2023
@owaiskazi19 owaiskazi19 changed the title Build script Added build script to generate artifacts Nov 14, 2023
@owaiskazi19
Copy link
Member Author

owaiskazi19 commented Nov 14, 2023 •
edited
Loading

Need review from @gaiksaya (EE team)

gaiksaya
gaiksaya reviewed Nov 14, 2023
View reviewed changes
scripts/build.sh Outdated Show resolved Hide resolved
@dbwiddis dbwiddis mentioned this pull request Nov 14, 2023
Closed
dbwiddis
dbwiddis approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending removal of dupe file)

@gaiksaya
Copy link
Member

gaiksaya commented Nov 14, 2023 •
edited
Loading

Cross posting from build issue:

I tried building this plugin. Just one issue, the plugin name does not match what is stated in the issue as well as repo name:

      plugins:
        - plugins/opensearch-flow-framework-2.12.0.0.zip
    version: 2.12.0.0

Please fix this. Thanks!

@joshpalis
Copy link
Member

@owaiskazi19 perhaps its time to change the repo name since we've opted not to use ai in our plugin

@owaiskazi19
Copy link
Member Author

@owaiskazi19 perhaps its time to change the repo name since we've opted not to use ai in our plugin

#168

@owaiskazi19
Copy link
Member Author

Let's hold this PR until #168 is completed.

@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (56ccb1d) 68.39% compared to head (709881b) 71.12%.
Report is 3 commits behind head on main.

Files Patch % Lines
...flowframework/workflow/RegisterLocalModelStep.java 91.13% 4 Missing and 3 partials ⚠️
...a/org/opensearch/flowframework/model/Template.java 92.15% 3 Missing and 1 partial ⚠️
...lowframework/workflow/RegisterRemoteModelStep.java 86.95% 1 Missing and 2 partials ⚠️
...ensearch/flowframework/workflow/GetMLTaskStep.java 92.85% 1 Missing and 1 partial ⚠️
...framework/indices/FlowFrameworkIndicesHandler.java 0.00% 1 Missing ⚠️
.../opensearch/flowframework/model/WorkflowState.java 0.00% 1 Missing ⚠️
...pensearch/flowframework/util/RestHandlerUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #166      +/-   ##
============================================
+ Coverage     68.39%   71.12%   +2.73%     
- Complexity      339      368      +29     
============================================
  Files            45       47       +2     
  Lines          1585     1728     +143     
  Branches        143      154      +11     
============================================
+ Hits           1084     1229     +145     
+ Misses          452      443       -9     
- Partials         49       56       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owaiskazi19 owaiskazi19 mentioned this pull request Nov 20, 2023
Closed
4 tasks
@owaiskazi19 owaiskazi19 merged commit f70f435 into opensearch-project:main Nov 21, 2023
19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 21, 2023
@github-actions
Added build script to generate artifacts (#166)
092fedc 
* Added build script to generate artifacts

Signed-off-by: Owais Kazi <[email protected]>

* Handled code coverage issue

Signed-off-by: Owais Kazi <[email protected]>

* Added missing jar and source jars

Signed-off-by: Owais Kazi <[email protected]>

* Matched maven artifacts name and removed build script

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit f70f435)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 21, 2023
Merged
owaiskazi19 added a commit that referenced this pull request Nov 21, 2023
@opensearch-trigger-bot @github-actions @owaiskazi19
[Backport 2.x] Added build script to generate artifacts (#184)
a233a39 
Added build script to generate artifacts (#166)

* Added build script to generate artifacts



* Handled code coverage issue



* Added missing jar and source jars



* Matched maven artifacts name and removed build script



---------


(cherry picked from commit f70f435)

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Owais Kazi <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 27, 2023
@github-actions
Added build script to generate artifacts (#166)
fb25c61 
* Added build script to generate artifacts

Signed-off-by: Owais Kazi <[email protected]>

* Handled code coverage issue

Signed-off-by: Owais Kazi <[email protected]>

* Added missing jar and source jars

Signed-off-by: Owais Kazi <[email protected]>

* Matched maven artifacts name and removed build script

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit f70f435)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 27, 2023
Merged
joshpalis pushed a commit that referenced this pull request Nov 27, 2023
@opensearch-trigger-bot @github-actions
[Backport feature/agent_framework] Added build script to generate art…
9661ddb 
…ifacts (#202)

Added build script to generate artifacts (#166)

* Added build script to generate artifacts



* Handled code coverage issue



* Added missing jar and source jars



* Matched maven artifacts name and removed build script



---------


(cherry picked from commit f70f435)

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitgalitz amitgalitz amitgalitz approved these changes

@gaiksaya gaiksaya gaiksaya approved these changes

@dbwiddis dbwiddis dbwiddis approved these changes

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

Assignees
No one assigned
Labels
backport feature/agent_framework backport 2.x backport PRs to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@owaiskazi19 @gaiksaya @joshpalis @dbwiddis @amitgalitz