Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates exception handling with FlowFrameworkException AND adds dryrun param to Create Workflow #137

Merged
merged 26 commits into from
Nov 3, 2023

Adding dry run test

a72904a
Select commit
Loading
Failed to load commit list.
Merged

Updates exception handling with FlowFrameworkException AND adds dryrun param to Create Workflow #137

Adding dry run test
a72904a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 3, 2023 in 1s

31.20% of diff hit (target 70.00%)

View this Pull Request on Codecov

31.20% of diff hit (target 70.00%)

Annotations

Check warning on line 153 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L153 

Added line #L153 was not covered by tests

Check warning on line 188 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L186-L188 

Added lines #L186 - L188 were not covered by tests

Check warning on line 191 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L190-L191 

Added lines #L190 - L191 were not covered by tests

Check warning on line 203 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L201-L203 

Added lines #L201 - L203 were not covered by tests

Check warning on line 206 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L205-L206 

Added lines #L205 - L206 were not covered by tests

Check warning on line 220 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L217-L220 

Added lines #L217 - L220 were not covered by tests

Check warning on line 231 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L229-L231 

Added lines #L229 - L231 were not covered by tests

Check warning on line 295 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L293-L295 

Added lines #L293 - L295 were not covered by tests

Check warning on line 334 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L332-L334 

Added lines #L332 - L334 were not covered by tests

Check warning on line 340 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L338-L340 

Added lines #L338 - L340 were not covered by tests

Check warning on line 369 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L367-L369 

Added lines #L367 - L369 were not covered by tests

Check warning on line 390 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L390 

Added line #L390 was not covered by tests

Check warning on line 403 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L401-L403 

Added lines #L401 - L403 were not covered by tests

Check warning on line 180 in src/main/java/org/opensearch/flowframework/model/Template.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/model/Template.java#L180 

Added line #L180 was not covered by tests

Check warning on line 69 in src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java#L68-L69 

Added lines #L68 - L69 were not covered by tests

Check warning on line 71 in src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java#L71 

Added line #L71 was not covered by tests

Check warning on line 76 in src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java#L73-L76 

Added lines #L73 - L76 were not covered by tests

Check warning on line 84 in src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java#L78-L84 

Added lines #L78 - L84 were not covered by tests

Check warning on line 77 in src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java#L73-L77 

Added lines #L73 - L77 were not covered by tests

Check warning on line 85 in src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java#L79-L85 

Added lines #L79 - L85 were not covered by tests

Check warning on line 89 in src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L89 

Added line #L89 was not covered by tests

Check warning on line 95 in src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L95 

Added line #L95 was not covered by tests

Check warning on line 98 in src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L98 

Added line #L98 was not covered by tests

Check warning on line 113 in src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L113 

Added line #L113 was not covered by tests

Check warning on line 115 in src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L115 

Added line #L115 was not covered by tests
View more details on Codecov