Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates exception handling with FlowFrameworkException AND adds dryrun param to Create Workflow #137

Merged
merged 26 commits into from
Nov 3, 2023

Adding dryrun param to create workflow API, allows for validation bef…

eefe602
Select commit
Loading
Failed to load commit list.
Merged

Updates exception handling with FlowFrameworkException AND adds dryrun param to Create Workflow #137

Adding dryrun param to create workflow API, allows for validation bef…
eefe602
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 2, 2023 in 1s

32.38% of diff hit (target 70.00%)

View this Pull Request on Codecov

32.38% of diff hit (target 70.00%)

Annotations

Check warning on line 153 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L153 

Added line #L153 was not covered by tests

Check warning on line 187 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L187 

Added line #L187 was not covered by tests

Check warning on line 190 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L189-L190 

Added lines #L189 - L190 were not covered by tests

Check warning on line 202 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L201-L202 

Added lines #L201 - L202 were not covered by tests

Check warning on line 213 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L213 

Added line #L213 was not covered by tests

Check warning on line 222 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L222 

Added line #L222 was not covered by tests

Check warning on line 285 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L285 

Added line #L285 was not covered by tests

Check warning on line 323 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L323 

Added line #L323 was not covered by tests

Check warning on line 328 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L328 

Added line #L328 was not covered by tests

Check warning on line 356 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L356 

Added line #L356 was not covered by tests

Check warning on line 377 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L377 

Added line #L377 was not covered by tests

Check warning on line 389 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L389 

Added line #L389 was not covered by tests

Check warning on line 180 in src/main/java/org/opensearch/flowframework/model/Template.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/model/Template.java#L180 

Added line #L180 was not covered by tests

Check warning on line 69 in src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java#L68-L69 

Added lines #L68 - L69 were not covered by tests

Check warning on line 71 in src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java#L71 

Added line #L71 was not covered by tests

Check warning on line 76 in src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java#L73-L76 

Added lines #L73 - L76 were not covered by tests

Check warning on line 84 in src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java#L78-L84 

Added lines #L78 - L84 were not covered by tests

Check warning on line 77 in src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java#L73-L77 

Added lines #L73 - L77 were not covered by tests

Check warning on line 85 in src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java#L79-L85 

Added lines #L79 - L85 were not covered by tests

Check warning on line 90 in src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L89-L90 

Added lines #L89 - L90 were not covered by tests

Check warning on line 93 in src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L92-L93 

Added lines #L92 - L93 were not covered by tests

Check warning on line 95 in src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L95 

Added line #L95 was not covered by tests

Check warning on line 98 in src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L97-L98 

Added lines #L97 - L98 were not covered by tests

Check warning on line 113 in src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L113 

Added line #L113 was not covered by tests

Check warning on line 115 in src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L115 

Added line #L115 was not covered by tests
View more details on Codecov