Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Remove Demo Classes, add No-Op Step #132

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9dffc0a from #129.

* Remove Demo Classes, add No-Op Step

Signed-off-by: Daniel Widdis <[email protected]>

* Add test coverage

Signed-off-by: Daniel Widdis <[email protected]>

* Revert enum javadocs as they are handled by #119

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Co-authored-by: Owais Kazi <[email protected]>
(cherry picked from commit 9dffc0a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #132 (83c9cd7) into 2.x (4effda0) will increase coverage by 0.37%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x     #132      +/-   ##
============================================
+ Coverage     66.71%   67.09%   +0.37%     
- Complexity      272      276       +4     
============================================
  Files            34       35       +1     
  Lines          1322     1319       -3     
  Branches        125      125              
============================================
+ Hits            882      885       +3     
+ Misses          395      390       -5     
+ Partials         45       44       -1     
Files Coverage Δ
...rg/opensearch/flowframework/workflow/NoOpStep.java 100.00% <100.00%> (ø)
...ch/flowframework/workflow/WorkflowStepFactory.java 100.00% <100.00%> (+28.57%) ⬆️

@joshpalis joshpalis merged commit dd1963b into 2.x Oct 31, 2023
26 checks passed
@github-actions github-actions bot deleted the backport/backport-129-to-2.x branch October 31, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant