[Backport 2.x] Added Create Connector Step #113

opensearch-trigger-bot · 2023-10-25T17:13:52Z

Backport 23b2f15 from #107.

* Added initial implementation of create connector Signed-off-by: Owais Kazi <[email protected]> * Added test for create connector Signed-off-by: Owais Kazi <[email protected]> * Added more tests and updated MLClient initialization Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comments Signed-off-by: Owais Kazi <[email protected]> * CompletedFuture exceptionally if fields are not present Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit 23b2f15) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

codecov · 2023-10-25T17:17:22Z

Codecov Report

Merging #113 (f17691a) into 2.x (a653645) will decrease coverage by 0.91%.
Report is 1 commits behind head on 2.x.
The diff coverage is 77.52%.

@@             Coverage Diff              @@
##                2.x     #113      +/-   ##
============================================
- Coverage     81.46%   80.55%   -0.91%     
+ Complexity      285      262      -23     
============================================
  Files            30       30              
  Lines          1122     1039      -83     
  Branches        126      103      -23     
============================================
- Hits            914      837      -77     
- Misses          162      164       +2     
+ Partials         46       38       -8

Files	Coverage Δ
.../opensearch/flowframework/FlowFrameworkPlugin.java	`100.00% <100.00%> (ø)`
...g/opensearch/flowframework/common/CommonValue.java	`100.00% <ø> (ø)`
...ch/flowframework/indices/GlobalContextHandler.java	`72.22% <100.00%> (ø)`
...a/org/opensearch/flowframework/model/Template.java	`88.80% <ø> (+1.52%)`	⬆️
...rk/transport/ProvisionWorkflowTransportAction.java	`45.61% <100.00%> (ø)`
...ch/flowframework/workflow/WorkflowStepFactory.java	`70.00% <100.00%> (+1.57%)`	⬆️
...arch/flowframework/workflow/RegisterModelStep.java	`78.94% <85.71%> (+5.73%)`	⬆️
...search/flowframework/workflow/DeployModelStep.java	`75.00% <71.42%> (+9.78%)`	⬆️
...ch/flowframework/workflow/CreateConnectorStep.java	`73.84% <73.84%> (ø)`

... and 1 file with indirect coverage changes

joshpalis · 2023-10-25T17:18:57Z

Failing check

Error: Exception in thread "main" java.net.SocketException: Software caused connection abort: socket write error
	at java.base/java.net.SocketOutputStream.socketWrite0(Native Method)
	at java.base/java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:1[10](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:11))
	at java.base/java.net.SocketOutputStream.write(SocketOutputStream.java:150)
	at java.base/sun.security.ssl.SSLSocketOutputRecord.encodeChangeCipherSpec(SSLSocketOutputRecord.java:231)
	at java.base/sun.security.ssl.OutputRecord.changeWriteCiphers(OutputRecord.java:187)
	at java.base/sun.security.ssl.ChangeCipherSpec$T10ChangeCipherSpecProducer.produce(ChangeCipherSpec.java:[11](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:12)8)
	at java.base/sun.security.ssl.Finished$T[12](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:13)FinishedProducer.onProduceFinished(Finished.java:395)
	at java.base/sun.security.ssl.Finished$T12FinishedProducer.produce(Finished.java:379)
	at java.base/sun.security.ssl.SSLHandshake.produce(SSLHandshake.java:436)
	at java.base/sun.security.ssl.ServerHelloDone$ServerHelloDoneConsumer.consume(ServerHelloDone.java:182)
	at java.base/sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:392)
	at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:443)
	at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:421)
	at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:183)
	at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:172)
	at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1511)
	at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:[14](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:15)21)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:456)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:427)
	at java.base/sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:580)
	at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:201)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:[15](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:16)92)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1520)
	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:250)
	at org.gradle.wrapper.Download.downloadInternal(Download.java:129)
	at org.gradle.wrapper.Download.download(Download.java:109)
	at org.gradle.wrapper.Install.forceFetch(Install.java:[17](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:18)1)
	at org.gradle.wrapper.Install.fetchDistribution(Install.java:104)
	at org.gradle.wrapper.Install.access$[40](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:41)0(Install.java:46)
	at org.gradle.wrapper.Install$1.call(Install.java:81)
	at org.gradle.wrapper.Install$1.call(Install.java:68)
	at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:69)
	at org.gradle.wrapper.Install.createDist(Install.java:68)
	at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:102)
	at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:66)
Error: Process completed with exit code 1.

owaiskazi19 · 2023-10-25T17:36:30Z

Failing check

Error: Exception in thread "main" java.net.SocketException: Software caused connection abort: socket write error
	at java.base/java.net.SocketOutputStream.socketWrite0(Native Method)
	at java.base/java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:1[10](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:11))
	at java.base/java.net.SocketOutputStream.write(SocketOutputStream.java:150)
	at java.base/sun.security.ssl.SSLSocketOutputRecord.encodeChangeCipherSpec(SSLSocketOutputRecord.java:231)
	at java.base/sun.security.ssl.OutputRecord.changeWriteCiphers(OutputRecord.java:187)
	at java.base/sun.security.ssl.ChangeCipherSpec$T10ChangeCipherSpecProducer.produce(ChangeCipherSpec.java:[11](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:12)8)
	at java.base/sun.security.ssl.Finished$T[12](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:13)FinishedProducer.onProduceFinished(Finished.java:395)
	at java.base/sun.security.ssl.Finished$T12FinishedProducer.produce(Finished.java:379)
	at java.base/sun.security.ssl.SSLHandshake.produce(SSLHandshake.java:436)
	at java.base/sun.security.ssl.ServerHelloDone$ServerHelloDoneConsumer.consume(ServerHelloDone.java:182)
	at java.base/sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:392)
	at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:443)
	at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:421)
	at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:183)
	at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:172)
	at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1511)
	at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:[14](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:15)21)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:456)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:427)
	at java.base/sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:580)
	at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:201)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:[15](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:16)92)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1520)
	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:250)
	at org.gradle.wrapper.Download.downloadInternal(Download.java:129)
	at org.gradle.wrapper.Download.download(Download.java:109)
	at org.gradle.wrapper.Install.forceFetch(Install.java:[17](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:18)1)
	at org.gradle.wrapper.Install.fetchDistribution(Install.java:104)
	at org.gradle.wrapper.Install.access$[40](https://github.com/opensearch-project/opensearch-ai-flow-framework/actions/runs/6643830790/job/18051756497?pr=113#step:4:41)0(Install.java:46)
	at org.gradle.wrapper.Install$1.call(Install.java:81)
	at org.gradle.wrapper.Install$1.call(Install.java:68)
	at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:69)
	at org.gradle.wrapper.Install.createDist(Install.java:68)
	at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:102)
	at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:66)
Error: Process completed with exit code 1.

Flaky CI failure of Windows. Ran on the second attempt.

opensearch-trigger-bot bot requested review from dbwiddis, owaiskazi19, joshpalis, ohltyler, amitgalitz and jackiehanyang as code owners October 25, 2023 17:13

owaiskazi19 approved these changes Oct 25, 2023

View reviewed changes

owaiskazi19 merged commit 2ff9ed6 into 2.x Oct 25, 2023
26 checks passed

github-actions bot deleted the backport/backport-107-to-2.x branch October 25, 2023 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.x] Added Create Connector Step #113

[Backport 2.x] Added Create Connector Step #113

opensearch-trigger-bot bot commented Oct 25, 2023

codecov bot commented Oct 25, 2023 •

edited

Loading

joshpalis commented Oct 25, 2023

owaiskazi19 commented Oct 25, 2023

[Backport 2.x] Added Create Connector Step #113

[Backport 2.x] Added Create Connector Step #113

Conversation

opensearch-trigger-bot bot commented Oct 25, 2023

codecov bot commented Oct 25, 2023 • edited Loading

Codecov Report

joshpalis commented Oct 25, 2023

owaiskazi19 commented Oct 25, 2023

codecov bot commented Oct 25, 2023 •

edited

Loading