Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for star tree index feature #8598
Add documentation for star tree index feature #8598
Changes from 31 commits
95a47ac
78b4c41
0e0483a
dcf47cf
8ecd473
d8357ae
ffdc6dc
b3b5783
05edca0
69387a2
06848eb
5f51c3a
e5cf72d
47de351
759a258
db0e127
f4d3a79
b4205dd
4aea8bf
1dd9302
f7ef88f
37c6f11
704212a
fe891e6
01d1eef
521fbb0
6a5d89e
d249946
6ce9d22
c0c5ec0
e8bdea5
3e372f7
19eaad0
f98e02d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 33 in _field-types/supported-field-types/index.md
GitHub Actions / style-job
Check failure on line 13 in _field-types/supported-field-types/star-tree.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about following :
The following example API request creates a corresponding star-tree index configuration under
request_aggs
"all
request_aggs
" for me sounds a bit confusingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confused on this -
config
itself doesn't have aname
property. Can we remove this ?Under config , user can specify
ordered_dimensions
,metrics
,max_leaf_docs
andskip_star_node_creation_for_dimensions
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove this. We have the definitions for
max_leaf_docs
andskip_star_node_creation_for_dimensions
on line 193.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
once a node crosses threshold of
max_leaf_docs, children nodes will be created based on the unique values
or something similar.