Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ngram tokenizer docs #8496

Merged
merged 6 commits into from
Dec 9, 2024
Merged

add ngram tokenizer docs #8496

merged 6 commits into from
Dec 9, 2024

Conversation

AntonEliatra
Copy link
Contributor

Description

add ngram tokenizer docs

Issues Resolved

Part of #1483 addressed in this PR.

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AntonEliatra
add ngram tokenizer docs
df93687 
Signed-off-by: Anton Rubin <[email protected]>
@github-actions GitHub Actions
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws kolchfa-aws assigned vagimeli and unassigned kolchfa-aws Oct 11, 2024
@vagimeli
Copy link
Contributor

@udabhas @varun-lodaya Please provide tech review approval to move this PR forward in the documentation process. Please review this week or provide a peer who can review it. Thank you.

@vagimeli vagimeli added 3 - Tech review PR: Tech review in progress Needs SME Waiting on input from subject matter expert Content gap analyzers labels Oct 11, 2024
AntonEliatra and others added 2 commits October 16, 2024 17:01
@AntonEliatra
updating parameter table
a331379 
Signed-off-by: Anton Rubin <[email protected]>
@kolchfa-aws
Doc review
2daa567 
Signed-off-by: Fanit Kolchina <[email protected]>
@kolchfa-aws kolchfa-aws assigned kolchfa-aws and unassigned vagimeli Dec 5, 2024
@kolchfa-aws kolchfa-aws added 5 - Editorial review PR: Editorial review in progress backport 2.18 PR: Backport label for 2.18 and removed 3 - Tech review PR: Tech review in progress labels Dec 5, 2024
natebower
natebower reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws @AntonEliatra Editorial review. Thanks!

_analyzers/tokenizers/ngram.md Outdated Show resolved Hide resolved
_analyzers/tokenizers/ngram.md Outdated Show resolved Hide resolved
_analyzers/tokenizers/ngram.md Outdated Show resolved Hide resolved
_analyzers/tokenizers/ngram.md Outdated Show resolved Hide resolved
_analyzers/tokenizers/ngram.md Outdated Show resolved Hide resolved
@kolchfa-aws @natebower
Apply suggestions from code review
cedcb58 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
@kolchfa-aws kolchfa-aws merged commit b203c4c into opensearch-project:main Dec 9, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@github-actions @kolchfa-aws @natebower
add ngram tokenizer docs (#8496)
574b691 
* add ngram tokenizer docs

Signed-off-by: Anton Rubin <[email protected]>

* updating parameter table

Signed-off-by: Anton Rubin <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit b203c4c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Dec 9, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
@opensearch-trigger-bot
add ngram tokenizer docs (#8496) (#8909)
77e2949
@AntonEliatra AntonEliatra deleted the adding-ngram-tokenizer-docs branch December 10, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@kolchfa-aws kolchfa-aws

Labels
5 - Editorial review PR: Editorial review in progress analyzers backport 2.18 PR: Backport label for 2.18 Content gap Needs SME Waiting on input from subject matter expert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AntonEliatra @vagimeli @natebower @kolchfa-aws